Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
6af7397f
Commit
6af7397f
authored
Jul 05, 2018
by
George Tsiolis
Committed by
Phil Hughes
Jul 05, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Close revoke deploy token modal on escape keypress
parent
a43b7d4a
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
31 additions
and
1 deletion
+31
-1
app/views/projects/deploy_tokens/_revoke_modal.html.haml
app/views/projects/deploy_tokens/_revoke_modal.html.haml
+1
-1
changelogs/unreleased/close-revoke-deploy-token-modal-on-escape-keypress.yml
...ed/close-revoke-deploy-token-modal-on-escape-keypress.yml
+5
-0
spec/features/projects/settings/user_sees_revoke_deploy_token_modal_spec.rb
...ects/settings/user_sees_revoke_deploy_token_modal_spec.rb
+25
-0
No files found.
app/views/projects/deploy_tokens/_revoke_modal.html.haml
View file @
6af7397f
.modal
{
id:
"revoke-modal-#{token.id}"
}
.modal
{
id:
"revoke-modal-#{token.id}"
,
tabindex:
-
1
}
.modal-dialog
.modal-dialog
.modal-content
.modal-content
.modal-header
.modal-header
...
...
changelogs/unreleased/close-revoke-deploy-token-modal-on-escape-keypress.yml
0 → 100644
View file @
6af7397f
---
title
:
Close revoke deploy token modal on escape keypress
merge_request
:
20347
author
:
George Tsiolis
type
:
changed
spec/features/projects/settings/user_sees_revoke_deploy_token_modal_spec.rb
0 → 100644
View file @
6af7397f
require
'rails_helper'
describe
'Repository Settings > User sees revoke deploy token modal'
,
:js
do
let
(
:project
)
{
create
(
:project
,
:public
,
:repository
)
}
let
(
:user
)
{
project
.
creator
}
let
(
:role
)
{
:developer
}
let!
(
:deploy_token
)
{
create
(
:deploy_token
,
:gitlab_deploy_token
,
projects:
[
project
])
}
before
do
project
.
add_role
(
user
,
role
)
sign_in
(
user
)
visit
(
project_settings_repository_path
(
project
))
click_link
(
'Revoke'
)
end
it
'shows the revoke deploy token modal'
do
expect
(
page
).
to
have_content
(
'You are about to revoke'
)
end
it
'closes the revoke deploy token modal with escape keypress'
do
find
(
'.modal.show'
).
send_keys
(
:escape
)
expect
(
page
).
not_to
have_content
(
'You are about to revoke'
)
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment