Commit 71ba3982 authored by Sean McGivern's avatar Sean McGivern

Merge branch '43345-spec-requests-api-project_import_spec-rb-fails' into 'master'

Resolve "spec/requests/api/project_import_spec.rb fails"

Closes #43345

See merge request gitlab-org/gitlab-ce!17184
parents 5d58949e d8dfec0f
...@@ -41,8 +41,12 @@ module API ...@@ -41,8 +41,12 @@ module API
current_user.namespace current_user.namespace
end end
project_params = import_params.merge(namespace_id: namespace.id, project_params = {
file: import_params[:file]['tempfile']) path: import_params[:path],
namespace_id: namespace.id,
file: import_params[:file]['tempfile']
}
project = ::Projects::GitlabProjectsImportService.new(current_user, project_params).execute project = ::Projects::GitlabProjectsImportService.new(current_user, project_params).execute
render_api_error!(project.errors.full_messages&.first, 400) unless project.saved? render_api_error!(project.errors.full_messages&.first, 400) unless project.saved?
......
...@@ -42,7 +42,7 @@ describe API::ProjectImport do ...@@ -42,7 +42,7 @@ describe API::ProjectImport do
it 'schedules an import at the user namespace level' do it 'schedules an import at the user namespace level' do
expect_any_instance_of(Project).not_to receive(:import_schedule) expect_any_instance_of(Project).not_to receive(:import_schedule)
expect(Gitlab::ImportExport::ProjectCreator).not_to receive(:new) expect(::Projects::CreateService).not_to receive(:new)
post api('/projects/import', user), namespace: 'nonexistent', path: 'test-import2', file: fixture_file_upload(file) post api('/projects/import', user), namespace: 'nonexistent', path: 'test-import2', file: fixture_file_upload(file)
...@@ -73,7 +73,7 @@ describe API::ProjectImport do ...@@ -73,7 +73,7 @@ describe API::ProjectImport do
def stub_import(namespace) def stub_import(namespace)
expect_any_instance_of(Project).to receive(:import_schedule) expect_any_instance_of(Project).to receive(:import_schedule)
expect(Gitlab::ImportExport::ProjectCreator).to receive(:new).with(namespace.id, any_args).and_call_original expect(::Projects::CreateService).to receive(:new).with(user, hash_including(namespace_id: namespace.id)).and_call_original
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment