Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
82b6f82f
Commit
82b6f82f
authored
Apr 16, 2018
by
Phil Hughes
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fixed web IDE not working for sub-groups
Closes #45412
parent
ddd7a81d
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
31 additions
and
1 deletion
+31
-1
app/assets/javascripts/ide/ide_router.js
app/assets/javascripts/ide/ide_router.js
+1
-1
changelogs/unreleased/ide-subgroup-fix.yml
changelogs/unreleased/ide-subgroup-fix.yml
+5
-0
spec/features/ide_spec.rb
spec/features/ide_spec.rb
+25
-0
No files found.
app/assets/javascripts/ide/ide_router.js
View file @
82b6f82f
...
...
@@ -36,7 +36,7 @@ const router = new VueRouter({
base
:
`
${
gon
.
relative_url_root
}
/-/ide/`
,
routes
:
[
{
path
:
'
/project/:namespace/:project
'
,
path
:
'
/project/:namespace/:project
*
'
,
component
:
EmptyRouterComponent
,
children
:
[
{
...
...
changelogs/unreleased/ide-subgroup-fix.yml
0 → 100644
View file @
82b6f82f
---
title
:
Fixed IDE not loading for sub groups
merge_request
:
author
:
type
:
fixed
spec/features/ide_spec.rb
0 → 100644
View file @
82b6f82f
require
'spec_helper'
describe
'IDE'
,
:js
do
describe
'sub-groups'
do
let
(
:user
)
{
create
(
:user
)
}
let
(
:group
)
{
create
(
:group
)
}
let
(
:subgroup
)
{
create
(
:group
,
parent:
group
)
}
let
(
:subgroup_project
)
{
create
(
:project
,
:repository
,
namespace:
subgroup
)
}
before
do
subgroup_project
.
add_master
(
user
)
sign_in
(
user
)
visit
project_path
(
subgroup_project
)
click_link
(
'Web IDE'
)
wait_for_requests
end
it
'loads project in web IDE'
do
expect
(
page
).
to
have_selector
(
'.context-header'
,
text:
subgroup_project
.
name
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment