Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
865341ac
Commit
865341ac
authored
Dec 08, 2017
by
Kamil Trzcinski
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix a bug of before_sha being inproperly evaluated to `checkout_sha`
parent
ad3be46b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
5 deletions
+1
-5
lib/gitlab/ci/pipeline/chain/command.rb
lib/gitlab/ci/pipeline/chain/command.rb
+1
-5
No files found.
lib/gitlab/ci/pipeline/chain/command.rb
View file @
865341ac
...
@@ -46,7 +46,7 @@ module Gitlab
...
@@ -46,7 +46,7 @@ module Gitlab
end
end
def
before_sha
def
before_sha
checkout_sha
||
before
_sha
||
Gitlab
::
Git
::
BLANK_SHA
before_sha
||
checkout
_sha
||
Gitlab
::
Git
::
BLANK_SHA
end
end
def
protected_ref?
def
protected_ref?
...
@@ -54,10 +54,6 @@ module Gitlab
...
@@ -54,10 +54,6 @@ module Gitlab
project
.
protected_for?
(
ref
)
project
.
protected_for?
(
ref
)
end
end
end
end
def
error
(
message
)
pipeline
.
errors
.
add
(
:base
,
message
)
end
end
end
end
end
end
end
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment