Commit 8c8fac87 authored by Phil Hughes's avatar Phil Hughes

Merge branch '59502-fix-breadcrumb-artifacts' into 'master'

Fixes link in artifacts breadcrumb

Closes #59502

See merge request gitlab-org/gitlab-ce!26592
parents 0610bb09 1cb82c4d
...@@ -4,7 +4,7 @@ ...@@ -4,7 +4,7 @@
= render "projects/jobs/header" = render "projects/jobs/header"
- add_to_breadcrumbs(s_('CICD|Jobs'), project_jobs_path(@project)) - add_to_breadcrumbs(s_('CICD|Jobs'), project_jobs_path(@project))
- add_to_breadcrumbs("##{@build.id}", project_jobs_path(@project)) - add_to_breadcrumbs("##{@build.id}", project_job_path(@project, @build))
.tree-holder .tree-holder
.nav-block .nav-block
......
---
title: Fixes job link in artifacts page breadcrumb
merge_request: 26592
author:
type: fixed
...@@ -19,6 +19,12 @@ describe "User browses artifacts" do ...@@ -19,6 +19,12 @@ describe "User browses artifacts" do
visit(browse_project_job_artifacts_path(project, job)) visit(browse_project_job_artifacts_path(project, job))
end end
it "renders a link to the job in the breadcrumbs" do
page.within('.js-breadcrumbs-list') do
expect(page).to have_link("##{job.id}", href: project_job_path(project, job))
end
end
it "shows artifacts" do it "shows artifacts" do
expect(page).not_to have_selector(".build-sidebar") expect(page).not_to have_selector(".build-sidebar")
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment