Commit 8e33e7cf authored by Douglas Barbosa Alexandre's avatar Douglas Barbosa Alexandre

Merge branch 'master' into 'master'

Change label of button "Create Pipeline" to "Run Pipeline"

See merge request gitlab-org/gitlab-ce!26943
parents 345fa58b 3ec62527
...@@ -10,7 +10,7 @@ ...@@ -10,7 +10,7 @@
= form_errors(@pipeline) = form_errors(@pipeline)
.form-group.row .form-group.row
.col-sm-12 .col-sm-12
= f.label :ref, s_('Pipeline|Create for'), class: 'col-form-label' = f.label :ref, s_('Pipeline|Run for'), class: 'col-form-label'
= hidden_field_tag 'pipeline[ref]', params[:ref] || @project.default_branch = hidden_field_tag 'pipeline[ref]', params[:ref] || @project.default_branch
= dropdown_tag(params[:ref] || @project.default_branch, = dropdown_tag(params[:ref] || @project.default_branch,
options: { toggle_class: 'js-branch-select wide monospace', options: { toggle_class: 'js-branch-select wide monospace',
...@@ -28,7 +28,7 @@ ...@@ -28,7 +28,7 @@
= (s_("Pipeline|Specify variable values to be used in this run. The values specified in %{settings_link} will be used by default.") % {settings_link: settings_link}).html_safe = (s_("Pipeline|Specify variable values to be used in this run. The values specified in %{settings_link} will be used by default.") % {settings_link: settings_link}).html_safe
.form-actions .form-actions
= f.submit s_('Pipeline|Create pipeline'), class: 'btn btn-success js-variables-save-button', tabindex: 3 = f.submit s_('Pipeline|Run Pipeline'), class: 'btn btn-success js-variables-save-button', tabindex: 3
= link_to _('Cancel'), project_pipelines_path(@project), class: 'btn btn-default float-right' = link_to _('Cancel'), project_pipelines_path(@project), class: 'btn btn-default float-right'
-# haml-lint:disable InlineJavaScript -# haml-lint:disable InlineJavaScript
......
---
title: Changed button label at /pipelines/new
merge_request: 26893
author: antfobe,leonardofl
type: other
...@@ -5947,12 +5947,6 @@ msgstr "" ...@@ -5947,12 +5947,6 @@ msgstr ""
msgid "Pipeline|Coverage" msgid "Pipeline|Coverage"
msgstr "" msgstr ""
msgid "Pipeline|Create for"
msgstr ""
msgid "Pipeline|Create pipeline"
msgstr ""
msgid "Pipeline|Duration" msgid "Pipeline|Duration"
msgstr "" msgstr ""
...@@ -5965,6 +5959,9 @@ msgstr "" ...@@ -5965,6 +5959,9 @@ msgstr ""
msgid "Pipeline|Run Pipeline" msgid "Pipeline|Run Pipeline"
msgstr "" msgstr ""
msgid "Pipeline|Run for"
msgstr ""
msgid "Pipeline|Search branches" msgid "Pipeline|Search branches"
msgstr "" msgstr ""
......
...@@ -685,7 +685,7 @@ describe 'Pipelines', :js do ...@@ -685,7 +685,7 @@ describe 'Pipelines', :js do
end end
it 'creates a new pipeline' do it 'creates a new pipeline' do
expect { click_on 'Create pipeline' } expect { click_on 'Run Pipeline' }
.to change { Ci::Pipeline.count }.by(1) .to change { Ci::Pipeline.count }.by(1)
expect(Ci::Pipeline.last).to be_web expect(Ci::Pipeline.last).to be_web
...@@ -698,7 +698,7 @@ describe 'Pipelines', :js do ...@@ -698,7 +698,7 @@ describe 'Pipelines', :js do
fill_in "Input variable value", with: "value" fill_in "Input variable value", with: "value"
end end
expect { click_on 'Create pipeline' } expect { click_on 'Run Pipeline' }
.to change { Ci::Pipeline.count }.by(1) .to change { Ci::Pipeline.count }.by(1)
expect(Ci::Pipeline.last.variables.map { |var| var.slice(:key, :secret_value) }) expect(Ci::Pipeline.last.variables.map { |var| var.slice(:key, :secret_value) })
...@@ -709,7 +709,7 @@ describe 'Pipelines', :js do ...@@ -709,7 +709,7 @@ describe 'Pipelines', :js do
context 'without gitlab-ci.yml' do context 'without gitlab-ci.yml' do
before do before do
click_on 'Create pipeline' click_on 'Run Pipeline'
end end
it { expect(page).to have_content('Missing .gitlab-ci.yml file') } it { expect(page).to have_content('Missing .gitlab-ci.yml file') }
...@@ -722,14 +722,14 @@ describe 'Pipelines', :js do ...@@ -722,14 +722,14 @@ describe 'Pipelines', :js do
click_link 'master' click_link 'master'
end end
expect { click_on 'Create pipeline' } expect { click_on 'Run Pipeline' }
.to change { Ci::Pipeline.count }.by(1) .to change { Ci::Pipeline.count }.by(1)
end end
end end
end end
end end
describe 'Create pipelines' do describe 'Run Pipelines' do
let(:project) { create(:project, :repository) } let(:project) { create(:project, :repository) }
before do before do
...@@ -740,7 +740,7 @@ describe 'Pipelines', :js do ...@@ -740,7 +740,7 @@ describe 'Pipelines', :js do
it 'has field to add a new pipeline' do it 'has field to add a new pipeline' do
expect(page).to have_selector('.js-branch-select') expect(page).to have_selector('.js-branch-select')
expect(find('.js-branch-select')).to have_content project.default_branch expect(find('.js-branch-select')).to have_content project.default_branch
expect(page).to have_content('Create for') expect(page).to have_content('Run for')
end end
end end
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment