Commit a1adb794 authored by Jacob Schatz's avatar Jacob Schatz

Fixes broken images on load of PNGs

parent 727c8a26
...@@ -13,6 +13,16 @@ const RepoBinaryViewer = { ...@@ -13,6 +13,16 @@ const RepoBinaryViewer = {
}, },
methods: { methods: {
errored() {
console.log('errored');
Store.binaryLoaded = false;
},
loaded() {
console.log('loaded');
Store.binaryLoaded = true;
},
isMarkdown() { isMarkdown() {
return this.activeFile.extension === 'md'; return this.activeFile.extension === 'md';
}, },
...@@ -30,6 +40,7 @@ const RepoBinaryViewer = { ...@@ -30,6 +40,7 @@ const RepoBinaryViewer = {
if (!this.binary) return; if (!this.binary) return;
switch (this.binaryMimeType) { switch (this.binaryMimeType) {
case 'image/png': case 'image/png':
console.log('png bitch')
this.binaryTypes.png = true; this.binaryTypes.png = true;
break; break;
default: default:
...@@ -45,7 +56,7 @@ export default RepoBinaryViewer; ...@@ -45,7 +56,7 @@ export default RepoBinaryViewer;
<template> <template>
<div id="binary-viewer" v-if="binary"> <div id="binary-viewer" v-if="binary">
<img v-if="binaryTypes.png" :src="pngBlobWithDataURI" :alt="activeFile.name"/> <img v-show="binaryTypes.png && binaryLoaded" @error="errored" @load="loaded" :src="pngBlobWithDataURI" :alt="activeFile.name"/>
<div v-if="binaryTypes.markdown" v-html="activeFile.html"></div> <div v-if="binaryTypes.markdown" v-html="activeFile.html"></div>
</div> </div>
</template> </template>
...@@ -24,6 +24,7 @@ const RepoStore = { ...@@ -24,6 +24,7 @@ const RepoStore = {
tabsOverflow: 41, tabsOverflow: 41,
tempPrivateToken: '', tempPrivateToken: '',
submitCommitsLoading: false, submitCommitsLoading: false,
binaryLoaded:false,
activeFile: { activeFile: {
active: true, active: true,
binary: false, binary: false,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment