Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
b1250065
Commit
b1250065
authored
Aug 29, 2016
by
Grzegorz Bizon
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Do not enforce using a hash with hidden ci key
parent
68b3c8c2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
14 deletions
+2
-14
lib/gitlab/ci/config/node/hidden_job.rb
lib/gitlab/ci/config/node/hidden_job.rb
+0
-1
spec/lib/gitlab/ci/config/node/hidden_job_spec.rb
spec/lib/gitlab/ci/config/node/hidden_job_spec.rb
+2
-13
No files found.
lib/gitlab/ci/config/node/hidden_job.rb
View file @
b1250065
...
...
@@ -9,7 +9,6 @@ module Gitlab
include
Validatable
validations
do
validates
:config
,
type:
Hash
validates
:config
,
presence:
true
end
...
...
spec/lib/gitlab/ci/config/node/hidden_job_spec.rb
View file @
b1250065
...
...
@@ -5,11 +5,11 @@ describe Gitlab::Ci::Config::Node::HiddenJob do
describe
'validations'
do
context
'when entry config value is correct'
do
let
(
:config
)
{
{
image:
'ruby:2.2'
}
}
let
(
:config
)
{
[
:some
,
:array
]
}
describe
'#value'
do
it
'returns key value'
do
expect
(
entry
.
value
).
to
eq
(
image:
'ruby:2.2'
)
expect
(
entry
.
value
).
to
eq
[
:some
,
:array
]
end
end
...
...
@@ -21,17 +21,6 @@ describe Gitlab::Ci::Config::Node::HiddenJob do
end
context
'when entry value is not correct'
do
context
'incorrect config value type'
do
let
(
:config
)
{
[
'incorrect'
]
}
describe
'#errors'
do
it
'saves errors'
do
expect
(
entry
.
errors
)
.
to
include
'hidden job config should be a hash'
end
end
end
context
'when config is empty'
do
let
(
:config
)
{
{}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment