Using plain if/else is much easier to understand

df5b7867 · Lin Jen-Shin · 2c27325e · df5b7867
Commit df5b7867 authored Jul 11, 2016 by Lin Jen-Shin
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 4 deletions

app/controllers/projects/artifacts_controller.rb app/controllers/projects/artifacts_controller.rb +4 -4

No files found.
--- a/app/controllers/projects/artifacts_controller.rb
+++ b/app/controllers/projects/artifacts_controller.rb
@@ -5,11 +5,11 @@ class Projects::ArtifactsController < Projects::ApplicationController
  before_action :validate_artifacts!

  def download
-    unless artifacts_file.file_storage?
-      return redirect_to artifacts_file.url
+    if artifacts_file.file_storage?
+      send_file artifacts_file.path, disposition: 'attachment'
+    else
+      redirect_to artifacts_file.url
    end
-
-    send_file artifacts_file.path, disposition: 'attachment'
  end

  def browse