Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
ee92accc
Commit
ee92accc
authored
May 23, 2019
by
Małgorzata Ksionek
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add specs for median serializing
parent
ddb2949b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
31 additions
and
0 deletions
+31
-0
app/serializers/analytics_stage_entity.rb
app/serializers/analytics_stage_entity.rb
+1
-0
spec/serializers/analytics_stage_serializer_spec.rb
spec/serializers/analytics_stage_serializer_spec.rb
+30
-0
No files found.
app/serializers/analytics_stage_entity.rb
View file @
ee92accc
...
...
@@ -10,6 +10,7 @@ class AnalyticsStageEntity < Grape::Entity
expose
:median
,
as: :value
do
|
stage
|
# median returns a BatchLoader instance which we first have to unwrap by using to_f
# we use to_f to make sure results below 1 are presented to the end-user
!
stage
.
median
.
to_f
.
zero?
?
distance_of_time_in_words
(
stage
.
median
)
:
nil
end
end
spec/serializers/analytics_stage_serializer_spec.rb
View file @
ee92accc
...
...
@@ -21,4 +21,34 @@ describe AnalyticsStageSerializer do
it
'contains important elements of AnalyticsStage'
do
expect
(
subject
).
to
include
(
:title
,
:description
,
:value
)
end
context
'when median is equal 0'
do
before
do
allow_any_instance_of
(
Gitlab
::
CycleAnalytics
::
BaseStage
).
to
receive
(
:median
).
and_return
(
0
)
end
it
'value is nil'
do
expect
(
subject
.
fetch
(
:value
)).
to
be_nil
end
end
context
'when median is below 1'
do
before
do
allow_any_instance_of
(
Gitlab
::
CycleAnalytics
::
BaseStage
).
to
receive
(
:median
).
and_return
(
0.12
)
end
it
'value is equal to median'
do
expect
(
subject
.
fetch
(
:value
)).
to
eq
(
'less than a minute'
)
end
end
context
'when median is above 1'
do
before
do
allow_any_instance_of
(
Gitlab
::
CycleAnalytics
::
BaseStage
).
to
receive
(
:median
).
and_return
(
1.12
)
end
it
'value is equal to median'
do
expect
(
subject
.
fetch
(
:value
)).
to
eq
(
'less than a minute'
)
end
end
end
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment