Commit f9c23de6 authored by Kushal Pandya's avatar Kushal Pandya

Use plain JS in `goToTodoUrl`, make comment more concise

parent 8a4da740
...@@ -146,20 +146,21 @@ ...@@ -146,20 +146,21 @@
} }
goToTodoUrl(e) { goToTodoUrl(e) {
const todoLink = $(this).data('url'); const todoLink = this.dataset.url;
let targetLink = $(e.target).attr('href'); let targetLink = e.target.getAttribute('href');
if ($(e.target).is('img')) { // See if clicked target was Avatar if (e.target.tagName === 'IMG') { // See if clicked target was Avatar
targetLink = $(e.target).parent().attr('href'); // Parent of Avatar is link targetLink = e.target.parentElement.getAttribute('href'); // Parent of Avatar is link
} }
if (!todoLink) { if (!todoLink) {
return; return;
} }
// Allow Meta-Click (Cmd+Click or Ctrl+Click) // Allow following special clicks to make link open in new tab
// or Mouse3-click (middle-click) // 1) Cmd + Click on Mac (e.metaKey)
// to open in a new tab // 2) Ctrl + Click on PC (e.ctrlKey)
// 3) Middle-click or Mouse Wheel Click (e.which is 2)
if (e.metaKey || e.ctrlKey || e.which === 2) { if (e.metaKey || e.ctrlKey || e.which === 2) {
e.preventDefault(); e.preventDefault();
// Meta-Click on username leads to different URL than todoLink. // Meta-Click on username leads to different URL than todoLink.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment