Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
G
gitlab-ce
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Léo-Paul Géneau
gitlab-ce
Commits
f9c23de6
Commit
f9c23de6
authored
Feb 07, 2017
by
Kushal Pandya
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use plain JS in `goToTodoUrl`, make comment more concise
parent
8a4da740
Changes
1
Show whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
7 deletions
+8
-7
app/assets/javascripts/todos.js.es6
app/assets/javascripts/todos.js.es6
+8
-7
No files found.
app/assets/javascripts/todos.js.es6
View file @
f9c23de6
...
@@ -146,20 +146,21 @@
...
@@ -146,20 +146,21 @@
}
}
goToTodoUrl(e) {
goToTodoUrl(e) {
const todoLink =
$(this).data('url')
;
const todoLink =
this.dataset.url
;
let targetLink =
$(e.target).attr
('href');
let targetLink =
e.target.getAttribute
('href');
if (
$(e.target).is('img')
) { // See if clicked target was Avatar
if (
e.target.tagName === 'IMG'
) { // See if clicked target was Avatar
targetLink =
$(e.target).parent().attr
('href'); // Parent of Avatar is link
targetLink =
e.target.parentElement.getAttribute
('href'); // Parent of Avatar is link
}
}
if (!todoLink) {
if (!todoLink) {
return;
return;
}
}
// Allow Meta-Click (Cmd+Click or Ctrl+Click)
// Allow following special clicks to make link open in new tab
// or Mouse3-click (middle-click)
// 1) Cmd + Click on Mac (e.metaKey)
// to open in a new tab
// 2) Ctrl + Click on PC (e.ctrlKey)
// 3) Middle-click or Mouse Wheel Click (e.which is 2)
if (e.metaKey || e.ctrlKey || e.which === 2) {
if (e.metaKey || e.ctrlKey || e.which === 2) {
e.preventDefault();
e.preventDefault();
// Meta-Click on username leads to different URL than todoLink.
// Meta-Click on username leads to different URL than todoLink.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment