To me it seems like the mock data does not match the actual data
anymore. I checked the actual data and to me it seems like the resolved
property actually should live in the overall discussion object.

The method that actually creates the favicon is already unit tested, I
would have loved to mock it out, but ist is not possible without using
rewire. So I decided we just check that the favicon href is changed and
use that as a proxy for calling `setFaviconOverlay`

Apparently the Array.sort function was used in a wrong way. Instead of
returning a number indicating order [0] it returned a boolean. This
fixes that.

[0]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort

Adds inter-service OpenTracing propagation

See merge request gitlab-org/gitlab-ce!24239

fix(labels): Move the primary button out of breadcrumbs and into the project section

Closes #56558

See merge request gitlab-org/gitlab-ce!24516

Upgrade gitlab-workhorse to 8.1.0

See merge request gitlab-org/gitlab-ce!24571

Improve localTimeAgo rendering

Closes #56327

See merge request gitlab-org/gitlab-ce!24389

Removes factories on Cluster background migration

See merge request gitlab-org/gitlab-ce!24536

Hashed Storage: `AfterRenameService` was not renaming Pages or Uploads folder on legacy storage

Closes #56636

See merge request gitlab-org/gitlab-ce!24526

Refactor Sidekiq workers to reduce differences between CE and EE

See merge request gitlab-org/gitlab-ce!24466

Edits to issues CSV import docs

See merge request gitlab-org/gitlab-ce!24554

This change allows the GitLab rails and sidekiq components to receive
tracing spans from upstream services such as Workhorse and pass these
spans on to downstream services including Gitaly and Sidekiq.

This change will also emit traces for incoming and outgoing requests
using the propagated trace information. This will allow operators and
engineers to view traces across the Workhorse, GitLab Rails, Sidekiq and
Gitaly components.

Additional intra-service instrumentation will be added in future
changes.

Changed the Caching of User Avatars to be public and to 5 minutes

See merge request gitlab-org/gitlab-ce!24546

Resolve "When ref is ambiguous, `CreatePipelineService` raises an error"

Closes #55966

See merge request gitlab-org/gitlab-ce!24437

Make favicon tests more fault resistent

Closes #50527

See merge request gitlab-org/gitlab-ce!22686

'Populate cluster kubernetes namespace' was using factories for their
specs. According to our documentation (see spec/migrations/readme.md),
we should use table helper to create a temproary ActiveRecord::Base
derived model for a table.

Update GitLab Runner Helm Chart to 0.1.45

See merge request gitlab-org/gitlab-ce!24564

Resolve "Related merge requests in issue design - Restyle"

Closes #47007

See merge request gitlab-org/gitlab-ce!24270

Change Monitoring to Monitor in docs dangerfile

See merge request gitlab-org/gitlab-ce!24570

Resolve "Limit sidekiq logging based on argument size"

Closes #56547

See merge request gitlab-org/gitlab-ce!24493

Use Gitaly 1.14.0

See merge request gitlab-org/gitlab-ce!24562

[QA] Backport Repository::Push and Git::Repository from EE

See merge request gitlab-org/gitlab-ce!24558

Resolve "Inconsistent text color for labels"

Closes #53714

See merge request gitlab-org/gitlab-ce!23873

Fix typos in dev & test docu

See merge request gitlab-org/gitlab-ce!24539

Add hyperlink to PAT doco

Closes #56650

See merge request gitlab-org/gitlab-ce!24551

Add notes about gitaly network architecture

See merge request gitlab-org/gitlab-ce!24563

Move the CNG triggering to a dedicated job in the `test` stage

Closes #56660

See merge request gitlab-org/gitlab-ce!24538

Resolve "Redirect projects/:id to project page"

Closes #53671

See merge request gitlab-org/gitlab-ce!24467

We still rely on the Dirty API for project rename (before/after) values,
but we don't access the dirty api from the service class anymore.

The previous value is now part of the initialization, which makes it
easier to test and the behavior is clearer.

The same was done with the `rename_repo` on the Storage classes, we now
provide before and after values as part of the method signature.

Also removed unnecessary comment

When logging arguments from Sidekiq to JSON, restrict the size of `args`
to 10 KB (when converted to JSON). This is to avoid blowing up with
excessively large job payloads.