1. 15 Dec, 2017 1 commit
    • Sean McGivern's avatar
      Don't use Markdown cache for stubbed settings in specs · 10885edf
      Sean McGivern authored
      The ApplicationSetting model uses the CacheMarkdownField concern, which updates
      the cached HTML when the field is updated in the database. However, in specs,
      when we want to test conditions using ApplicationSetting, we stub it, because
      this is accessed in different ways throughout the application.
      
      This means that if a spec runs that caches one of the Markdown fields, and a
      later spec uses `stub_application_setting` to set the raw value of that field,
      the cached value was still the original one. We can work around this by ignoring
      the Markdown cache in contexts where we're using `stub_application_setting`.
      
      We could be smarter, and only do this on the Markdown fields of the model, but
      this is probably fine.
      10885edf
  2. 14 Dec, 2017 20 commits
  3. 13 Dec, 2017 19 commits