- 14 Oct, 2018 2 commits
-
-
Thong Kuah authored
Remove the inheritance from ::BaseService which is causing us to inherit the initializer that has project as the first arg, as we will not have access to project with forthcoming group clusters. Also call install service from create service - 1 less thing to re-use Extract TestRequest code into a spec helper. Given that we need different behaviour for Rails 5.0 (and again in Rails 5.1!), it's handy to have that branching behaviour in one place
-
Thong Kuah authored
This should help with code re-use when we create applications for group level cluster next. Change `find_or_initialize_by` to explicitly find or build the right association based on the application name. The benefit here is that we use the associations on @cluster rather than querying from the other side of the association.
-
- 11 Oct, 2018 29 commits
-
-
Mike Greiling authored
4. enable jasmine/prefer-jasmine-matcher See merge request gitlab-org/gitlab-ce!22236
-
Mike Greiling authored
1. enable jasmine/new-line-between-declarations See merge request gitlab-org/gitlab-ce!22230
-
Mike Greiling authored
Fix erased block not being rendered when job was erased Closes #52570 See merge request gitlab-org/gitlab-ce!22294
-
Filipa Lacerda authored
-
Annabel Dunstone Gray authored
Update copy to clipboard button data for application secret Closes #52572 See merge request gitlab-org/gitlab-ce!22268
-
Robert Speicher authored
Fix project deletion when there is a export available Closes #52362 See merge request gitlab-org/gitlab-ce!22276
-
Rémy Coutable authored
Support pushing of feature flags to the frontend Closes gitlab-org/release/framework#17 See merge request gitlab-org/gitlab-ce!22197
-
Tim Zallmann authored
Adds `.json` to the end of pipelines endpoint Closes #52472 See merge request gitlab-org/gitlab-ce!22293
-
Tim Zallmann authored
Stuck block URL links to runners settings Closes #52519 See merge request gitlab-org/gitlab-ce!22286
-
Filipa Lacerda authored
-
Yorick Peterse authored
This adds a method to Gitlab::GonHelper called `push_frontend_feature_flag`. This method can be used to easily expose the state of a feature flag to Javascript code. For example, using this method we may write the following controller code: before_action do push_frontend_feature_flag(:vim_bindings) end def index # ... end def edit # ... end In Javascript we can then check the state of the flag as follows: if ( gon.features.vimBindings ) { // ... } Fixes https://gitlab.com/gitlab-org/release/framework/issues/17
-
Rémy Coutable authored
Enable even more frozen string in lib/**/*.rb See merge request gitlab-org/gitlab-ce!22206
-
Douglas Barbosa Alexandre authored
Feature improved branch filter sorting See merge request gitlab-org/gitlab-ce!22166
-
Jason Rutherford authored
-
Rémy Coutable authored
Instance SAML SSO e2e test Closes gitlab-qa#257 See merge request gitlab-org/gitlab-ce!22271
-
Douglas Barbosa Alexandre authored
Add new sort option "most_stars" to "Group > Children" pages See merge request gitlab-org/gitlab-ce!22121
-
Rene Hennig authored
-
Filipa Lacerda authored
-
Filipa Lacerda authored
When the job page is rendered we fetch the pipeline endpoint to render the stages in the sidebar. Without `.json` the response is cached, and when the user goes back to the pipeline's page it renders the json output instead of the Vue app
-
Achilleas Pipinellis authored
Removes link to deprecated project See merge request gitlab-org/gitlab-ce!22281
-
Achilleas Pipinellis authored
docs: match where statements at in omnibus section See merge request gitlab-org/gitlab-ce!22214
-
Achilleas Pipinellis authored
Avoid conflicting anchor name in documentation See merge request gitlab-org/gitlab-ce!22213
-
Sean McGivern authored
Update GitLab Shell to v8.4.0 for new Gitaly auth scheme Closes gitaly#1319 See merge request gitlab-org/gitlab-ce!22270
-
Rémy Coutable authored
QA: Add test of adding a member to a project See merge request gitlab-org/gitlab-ce!21753
-
Sanad Liaquat authored
Use ACCEPT_INSECURE_CERTS env var and fix step Simplify saml signin Fix rubo cop offence Add missing # frozen_string_literal: true
-
Evan Read authored
- Also fixes minor style issues.
-
Evan Read authored
Documentation for delayed jobs Closes #52127 See merge request gitlab-org/gitlab-ce!22117
-
Winnie Hellmann authored
-
Evan Read authored
Add Filesystem Performance Benchmarking documentation See merge request gitlab-org/gitlab-ce!22202
-
- 10 Oct, 2018 9 commits
-
-
Robert Speicher authored
Revert GitLab Pages version to v1.1.0 See merge request gitlab-org/gitlab-ce!22277
-
Stan Hu authored
Project deletions were failing with "Can't modify frozen hash" because: 1. Project#remove_exports was called in the after_destroy hook 2. This would remove the file and update ImportExportUpload 3. ImportExportUpload#save would attempt to write to a destroyed model To avoid this, we just check if ImportExportUpload has been destroyed before attempting to save it. This would have a side effect of not running after_commit hooks to delete the repository on disk, making it impossible to delete the project entirely. Closes #52362
-
Stan Hu authored
This works around the problem with domains not working due to https://gitlab.com/gitlab-org/gitlab-pages/issues/170.
-
Mark Lapierre authored
Adds a new QA test and the required page objects and related changes
-
Drew Blessing authored
Filesystem performance can have a big impact on overall GitLab performance, especially for actions that read or write Git repositories. This information will help benchmark filesystem performance against known good and bad real-world systems.
-
Tim Zallmann authored
Prettify all the things (part 5) See merge request gitlab-org/gitlab-ce!22255
-
Tim Zallmann authored
Prettify all the things (part 2) See merge request gitlab-org/gitlab-ce!22250
-
Clement Ho authored
Merge branch '52103-dropzone-css-is-failing-to-load-on-rspec-dev-and-staging-11-4-0-rc' into 'master' Resolve "Dropzone css is failing to load on rspec, dev and staging 11.4.0 RC" Closes #52103 See merge request gitlab-org/gitlab-ce!22272
-
Fatih Acet authored
Convert remaining issue board components into ES module syntax See merge request gitlab-org/gitlab-ce!22210
-