Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_19747456

* upstream/master: (116 commits)
  adds impersonator variable and makes sudo usage overall more clear
  Reenables /user API request to return private-token if user is admin and requested with sudo
  Fix Backup::Manager#remove_old
  Allow public access to some Tag API endpoints
  Update outdated visible content spec descriptions
  Grapify the issues API
  new DevOps report, 404s, typos
  Remove dashboard.scss
  Update custom_hooks.md for global custom hooks and chained hook info
  Move admin hooks spinach to rspec
  Move admin logs spinach test to rspec
  Fix 404 error when visit group label edit page
  A simpler implementation of finding a merge request
  Encourage bug reporters to mention if they use GitLab.com [ci skip]
  Bump gitlab-shell version to 4.0.3
  Remove confirmation.scss
  Explain "js: true" in "deleted_source_branch_spec.rb" [ci skip]
  Move award emojis to framwork
  Move image styles to framework
  Remove tags.scss
  ...

commits from the other repository. We'll cleanup
the tmp ref after we're done with our business.

more consistent across different methodst

We shouldn't pass a non-existing branch to source_branch.
Checkout test for:

* spec/features/tags/master_views_tags_spec.rb:24
* spec/features/projects/files/project_owner_sees_link_to_create_license_file_in_empty_project_spec.rb:13

by checking filename as well

Allow public access to some Tag API endpoints

Continuation of #4269.

See merge request !7896

Reenables /user API request to return private-token if user is admin and requested with sudo

## What does this MR do?

Reenables the API /users to return `private-token` when sudo is either a parameter or passed as a header and the user is admin.

## Screenshots (if relevant)

Without **sudo**:

![Screen_Shot_2016-11-21_at_11.44.49](/uploads/ebecf95dbadaf4a159b80c61c75771d9/Screen_Shot_2016-11-21_at_11.44.49.png)

With **sudo**:
![Screen_Shot_2016-11-21_at_11.45.52](/uploads/f25f9ddffcf2b921e9694e5a250191d3/Screen_Shot_2016-11-21_at_11.45.52.png)

## Does this MR meet the acceptance criteria?

- [x] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] API support added
- Tests
  - [x] Added for this feature/bug
  - [x] All builds are passing
- [x] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [x] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [x] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [x] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?


Closes #24537

See merge request !7615

Update outdated visible content spec descriptions

This fixes some spec descriptions that were not fixed in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7947.

See merge request !7971

Fix Backup::Manager#remove_old

Closes #25399

See merge request !7972

Fix typos in API doc examples

## What does this MR do?

Fixes a typo in the API docs. The `curl` examples in [build_triggers.md](doc/api/build_triggers.md) and [build_variables.md](doc/api/build_variables.md) all have a typo in the auth header. They all say `PRIVATE_TOKEN` when it should be `PRIVATE-TOKEN`.

## What are the relevant issue numbers?
Fixes #24565

See merge request !7514

Run builds with runners with tags gitlab-org and 2gb

## What does this MR do?

Added `gitlab-org` and `2gb` tags for jobs in `.gitlab-ci.yml`. So builds will be picked up by `gitlab-shared-runners-manager-X.gitlab.com runners`

## Are there points in the code the reviewer needs to double check?

Only `.gitlab-ci.yml`

## Why was this MR needed?

https://gitlab.com/gitlab-com/infrastructure/issues/714

## Screenshots (if relevant)


## Does this MR meet the acceptance criteria?

- [ ] [Changelog entry](https://docs.gitlab.com/ce/development/changelog.html) added
- [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [ ] API support added
- Tests
  - [ ] Added for this feature/bug
  - [ ] All builds are passing
- [ ] Conform by the [merge request performance guides](http://docs.gitlab.com/ce/development/merge_request_performance_guidelines.html)
- [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
- [ ] Branch has no merge conflicts with `master` (if it does - rebase it please)
- [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)

## What are the relevant issue numbers?

https://gitlab.com/gitlab-com/infrastructure/issues/714

See merge request !7757

have the branch existed upfront. That is,
`Rugged::Commit.create` rather than `Gitlab::Git::Blob.commit`
which the former doesn't need to have the branch but the latter
needs.

Grapify the issues API

Related to #22928

See merge request !7968

Update GLU index for new report, broken links + typos

## What does this MR do?
Update text on GLU documentation for spelling and new State of DevOps book. 

/cc @axil

See merge request !7962

So we still commit outside the hooks, and only
update ref inside the hooks. There are only two
exceptions:

* Whenever it's adding a tag. We can't add a tag
  without committing, unfortunately. See !7700
* Whenever source project is in another repository.
  We'll need to fetch ref otherwise commits can't be made.

See the whole discussion starting from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237#note_19210942

Bump Git version requirement to 2.8.4

Following gitlab-org/omnibus-gitlab!1108, the install doc and README should be updated too.

See merge request !7878

Bump gitlab-shell version to 4.0.3

See merge request !7953

Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/7237/diffs#note_19210818

Move admin hooks spinach to RSpec

https://gitlab.com/gitlab-org/gitlab-ce/issues/23036

See merge request !7942

Move admin logs spinach test to RSpec

https://gitlab.com/gitlab-org/gitlab-ce/issues/23036

See merge request !7945

Signed-off-by: Rémy Coutable <remy@rymai.me>

UX Guide - add initial animation guidance

Adding guidance to our UX Guide around animation. This is to help us implement #24831 and add polished, consistent animation throughout GitLab.

See merge request !7780

Use :maximum instead of :within for length validators with a 0..N range

Closes #25209

See merge request !7894