1. 19 Jul, 2016 36 commits
  2. 18 Jul, 2016 4 commits
    • Robert Speicher's avatar
      Merge branch 'cs-gemojione-3' into 'master' · a27212ab
      Robert Speicher authored
      Upgrade gemojione to 3.0.0
      
      Upgrades gemojione to 3.0.0, see the Changelog: https://github.com/jonathanwiesel/gemojione/blob/b98aa8b07eef815d4d3f52ff3c8714b28932b0de/CHANGELOG.md#v300-2016-07-12
      
      [Here are all the new 2016 emoji](http://emojione.com/releases/2.2.4/) 🎉
      
      This update has new emoji and more sensical categories.
      
      See merge request !5237
      a27212ab
    • Fatih Acet's avatar
      Merge branch 'mr-widget-alignment' into 'master' · ac828424
      Fatih Acet authored
      Fixed the alignment in the MR widget
      
      ## What does this MR do?
      
      Fixes the alignment of the browse button in the MR widget
      
      ## Screenshots (if relevant)
      
      ![Screen_Shot_2016-07-17_at_17.47.54](/uploads/41dcb0fad38fdd4dbccfda5ffaeaec6e/Screen_Shot_2016-07-17_at_17.47.54.png)
      
      See merge request !5307
      ac828424
    • Fatih Acet's avatar
      Merge branch 'sidebar-dropdowns-blur-link' into 'master' · a046a568
      Fatih Acet authored
      Blurs the clicked link in dropdown menus
      
      ## What does this MR do?
      
      This fixes an issue where the dropdown menu would stay visible even when clicked out of it
      
      See merge request !5322
      a046a568
    • Gabriel Mazetto's avatar
      Merge branch 'bug/sidekiq-cron-better-error' into 'master' · 777a0808
      Gabriel Mazetto authored
      Improve cron_jobs loading error messages
      
      ## What does this MR do?
      
      Improves the error message from "Sidekiq Cron Jobs" plugin, when trying to load a incorrect definition from gitlab config files.
      
      This is the output before the fix:
      
      ```
      2016-06-08T16:43:19.277Z 2890 TID-gso49ojro INFO: Booting Sidekiq 4.1.2 with redis options {:url=>"unix:/var/run/redis/redis.sock", :namespace=>"resque:gitlab"}
      undefined method `delete' for nil:NilClass
      /home/git/gitlab/config/initializers/sidekiq.rb:16:in `block (2 levels) in <top (required)>'
      /home/git/gitlab/config/initializers/sidekiq.rb:16:in `each'
      /home/git/gitlab/config/initializers/sidekiq.rb:16:in `block in <top (required)>'
      /home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/sidekiq-4.1.2/lib/sidekiq.rb:70:in `configure_server'
      ```
      
      This is the output after the fix:
      
      ```
      2016-07-18T10:53:22.414Z 66332 TID-oxal1bmik INFO: Booting Sidekiq 4.1.4 with redis options {:url=>"redis://localhost:6378", :namespace=>"resque:gitlab"}
      Invalid cron_jobs config key: 'registry'. Check your gitlab config file.
      /home/git/gitlab/config/initializers/sidekiq.rb:21:in `block (2 levels) in <top (required)>'
      /home/git/gitlab/config/initializers/sidekiq.rb:17:in `each'
      /home/git/gitlab/config/initializers/sidekiq.rb:17:in `block in <top (required)>'
      /home/git/gitlab/vendor/bundle/ruby/2.1.0/gems/ruby-2.1.8/gems/sidekiq-4.1.4/lib/sidekiq.rb:70:in `configure_server'
      ```
      
      Fixes #18378
      
      ## Are there points in the code the reviewer needs to double check?
      
      No
      
      ## Why was this MR needed?
      
      Original error doesn't give any hint on where the problem can be, so the user can't easily troubleshoot unless he knows implementation details.
      
      ## What are the relevant issue numbers?
      
      #18378
      
      ## Does this MR meet the acceptance criteria?
      
      - [ ] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG) entry added
      - [ ] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
      - [ ] API support added
      - Tests
        - [ ] Added for this feature/bug
        - [ ] All builds are passing
      - [ ] Conform by the [style guides](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#style-guides)
      - [ ] Branch has no merge conflicts with `master` (if you do - rebase it please)
      - [ ] [Squashed related commits together](https://git-scm.com/book/en/Git-Tools-Rewriting-History#Squashing-Commits)
      
      See merge request !5318
      777a0808