- 17 Apr, 2019 7 commits
-
-
Rémy Coutable authored
It seems the deploy function causes the job to fail if it doesn't succeed. That wasn't the intent as we want to curl the Review App after the deploy finished (even if it failed) because sometimes the Review App is just a bit long to be ready. This change wraps the Review App deployment with "set +e"/"set -e" to ensure that the job doesn't fail right away if the deploy fails. Signed-off-by: Rémy Coutable <remy@rymai.me>
-
Phil Hughes authored
Removes ifEE example for JS code. See merge request gitlab-org/gitlab-ce!27408
-
Phil Hughes authored
Add help texts to K8 form fields Closes #59275 See merge request gitlab-org/gitlab-ce!27274
-
Enrique Alcántara authored
-
Lin Jen-Shin authored
Fix logic in Api::Internal test See merge request gitlab-org/gitlab-ce!27193
-
Grzegorz Bizon authored
Allow extra args for helm in Auto-DevOps See merge request gitlab-org/gitlab-ce!26838
-
Michael Kozono authored
[CE backport] Fix no assignee text in sidebar_spec See merge request gitlab-org/gitlab-ce!27444
-
- 16 Apr, 2019 33 commits
-
-
Luke Bennett authored
-
Luke Duncalfe authored
The intention of this test is to ensure that the service class MergeRequests::PushOptionsHandlerService does not run when the :mr_push_options feature flag is disabled. This test was passing, however was not testing what it was supposed to be! For one, setting Feature.disable(:feature) in the test does not disable the feature, as rspec config in spec_helper stubs Feature to make all features enabled: https://gitlab.com/gitlab-org/gitlab-ce/commit/3ee48e422defaedd69946c607bd8d3672e510375 So the feature was still enabled in the test. But this test wasn't failing because unfortunately I had put: ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ``` instead of not_to! This meant that the `.new` method was being stubbed, so the service class did not create a MergeRequest, which satisfied the second expectation. ``` expect(MergeRequests::PushOptionsHandlerService).to receive(:new) ```
-
Stan Hu authored
Set correct timestamps when creating past issues Closes #58361 See merge request gitlab-org/gitlab-ce!27406
-
James Fargher authored
-
Annabel Dunstone Gray authored
`None` for assignees Closes #60599 See merge request gitlab-org/gitlab-ce!27419
-
Victor Wu authored
Update assignees_spec.js Update sidebar_spec.rb Update issues_spec.rb
-
Douglas Barbosa Alexandre authored
Test using Git 2.21 See merge request gitlab-org/gitlab-ce!27418
-
Michael Kozono authored
Resolve "Karma failing with MrWidgetAlertMessage when helpPath is provided Maximum call stack size exceeded" Closes #60605 See merge request gitlab-org/gitlab-ce!27429
-
Nathan Friend authored
-
Achilleas Pipinellis authored
Docs: CI/CD intro - add new illustration + description See merge request gitlab-org/gitlab-ce!27278
-
Marcia Ramos authored
-
Achilleas Pipinellis authored
Link to resource label events API See merge request gitlab-org/gitlab-ce!27412
-
Victor Wu authored
-
Filipa Lacerda authored
-
Marcia Ramos authored
Create frontend FAQ (documentation) See merge request gitlab-org/gitlab-ce!26372
-
Winnie Hellmann authored
-
Tim Zallmann authored
Replaced "View file" button with doc-text icon Closes #59034 See merge request gitlab-org/gitlab-ce!27365
-
Filipa Lacerda authored
Update merge request widget to accommodate post-merge pipelines See merge request gitlab-org/gitlab-ce!25983
-
Zeger-Jan van de Weg authored
-
Zeger-Jan van de Weg authored
-
Rémy Coutable authored
Fix minor typo in LDAP docs Closes #60413 See merge request gitlab-org/gitlab-ce!27415
-
Filipa Lacerda authored
Fix styling for `app/assets/stylesheets/pages/status.scss` Closes #59929 See merge request gitlab-org/gitlab-ce!26875
-
Kushal Pandya authored
Hide overflow in scoped labels Closes #48431 See merge request gitlab-org/gitlab-ce!27362
-
Zeger-Jan van de Weg authored
Given Rails doesn't use the Git binary anymore, this shouldn't be a problem.
-
Kamil Trzciński authored
Backport metrics report type See merge request gitlab-org/gitlab-ce!26798
-
Marcia Ramos authored
Update migration docs See merge request gitlab-org/gitlab-ce!27261
-
Michael Leopard authored
-
Marcia Ramos authored
Docs: Complete "Repository storage" directions See merge request gitlab-org/gitlab-ce!27346
-
Mark Fletcher authored
-
Kushal Pandya authored
Resolve "Tooltip for "View file" shows raw HTML" Closes #60533 See merge request gitlab-org/gitlab-ce!27398
-
Heinrich Lee Yu authored
Sets `system_note_timestamp` from `created_at`
-
Sean McGivern authored
Extract move quick action spec to shared example Closes #59570 See merge request gitlab-org/gitlab-ce!26907
-
Sean McGivern authored
Rewind iid on pipelines Closes #59362 See merge request gitlab-org/gitlab-ce!26490
-