Commits · cc91f09ac39a7c201d527734e835d01dc13e5059 · Léo-Paul Géneau / gitlab-ce · GitLab

18 Jul, 2016 8 commits
- Just use find_by! and we're rescuing ActiveRecord::RecordNotFound · cc91f09a
  Lin Jen-Shin authored Jul 18, 2016
```
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125645
```
  cc91f09a
- Match against records rather than id, feedback: · 6830e282
  Lin Jen-Shin authored Jul 18, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125605
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125611
```
  6830e282
- Use single line even if they're more than 80 chars, feedback: · 6de48227
  Lin Jen-Shin authored Jul 18, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125628
```
  6de48227
- Remove blank lines between clauses, feedback: · 6dcb75f9
  Lin Jen-Shin authored Jul 18, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125597
```
  6dcb75f9
- Use find_by, feedback: · 78c37bdd
  Lin Jen-Shin authored Jul 18, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125486
```
  78c37bdd
- Use RSpec helpers, feedback from: · 5151ebf4
  Lin Jen-Shin authored Jul 18, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13125543
```
  5151ebf4
- Fix dropdown caret · 39c1cabf
  Annabel Dunstone authored Jul 17, 2016
  
  39c1cabf
- Add artifacts download button on project page and branches page · 5c28f16a
  Annabel Dunstone authored Jul 17, 2016
  
  5c28f16a
17 Jul, 2016 1 commit
- Add artifacts to tags · faeaeda6
  Annabel Dunstone authored Jul 17, 2016
  
  faeaeda6
16 Jul, 2016 1 commit
- Add artifacts button · e313fd12
  Annabel Dunstone authored Jul 16, 2016
  
  e313fd12
14 Jul, 2016 16 commits
- Introduce Project#latest_success_builds_for: · 53a9dee6
  Lin Jen-Shin authored Jul 15, 2016
```
So it's more accessible for views to access the names of jobs.
Only filter Build#name from where we really need to download it.
```
  53a9dee6
- Try to make the URL more consistent between Rails and API · 4bb3787e
  Lin Jen-Shin authored Jul 15, 2016
  
  4bb3787e
- Fix outdated comment · c23f2aa5
  Lin Jen-Shin authored Jul 15, 2016
  
  c23f2aa5
- It could be redirecting or downloading in Rails or API · 2e90abf2
  Lin Jen-Shin authored Jul 15, 2016
  
  2e90abf2
- Add a download prefix so that we could add file prefix in the future · e96401f0
  Lin Jen-Shin authored Jul 15, 2016
  
  e96401f0
- now we're able to merge the spec · 398de9f1
  Lin Jen-Shin authored Jul 15, 2016
  
  398de9f1
- Avoid using let! · 640fc826
  Lin Jen-Shin authored Jul 15, 2016
  
  640fc826
- Provide the file directly rather than redirecting · c4496de8
  Lin Jen-Shin authored Jul 14, 2016
  
  c4496de8
- Serve artifacts from Builds · 70f508f5
  Lin Jen-Shin authored Jul 14, 2016
  
  70f508f5
- Merge features/projects/artifacts_spec.rb back · a9a8ceeb
  Lin Jen-Shin authored Jul 14, 2016
```
It doesn't make too much sense having this standalone
```
  a9a8ceeb
- Update routes based on feedback from: · d7bbee75
  Lin Jen-Shin authored Jul 14, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13058785

And note that job/build_name could contain `/`
```
  d7bbee75
- Prefer if so it's more clear what's going on · e01c421b
  Lin Jen-Shin authored Jul 14, 2016
  
  e01c421b
- Introduce get_build! so we could omit one early return · 1c7871e9
  Lin Jen-Shin authored Jul 14, 2016
  
  1c7871e9
- More descriptive local variable, feedback: · fab8bc53
  Lin Jen-Shin authored Jul 14, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13047190
```
  fab8bc53
- Remove blank line between if/else clause, feedback: · 55448528
  Lin Jen-Shin authored Jul 14, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13047184
```
  55448528
- Avoid shadowing CommitStatus#id, feedback: · 66b91ce9
  Lin Jen-Shin authored Jul 14, 2016
```
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/5142#note_13047163
```
  66b91ce9
13 Jul, 2016 6 commits
- rubocop likes this better · 5b227f35
  Lin Jen-Shin authored Jul 13, 2016
  
  5b227f35
- Share more stuffs · b043729d
  Lin Jen-Shin authored Jul 13, 2016
  
  b043729d
- Implement API for downloading artifacts from ref and build name: · 8735d95a
  Lin Jen-Shin authored Jul 13, 2016
```
Basically:

    GET /api/projects/:id/artifacts/:ref_name/:build_name

Also added tests for it.
```
  8735d95a
- Introduce path_from_ref and save some typing · 6c80b597
  Lin Jen-Shin authored Jul 13, 2016
  
  6c80b597
- Rename to ref_name so it's aligning with API · bb5f0671
  Lin Jen-Shin authored Jul 13, 2016
  
  bb5f0671
- No need for a separate line now · 33368281
  Lin Jen-Shin authored Jul 13, 2016
  
  33368281
12 Jul, 2016 8 commits
- save some lines and a local variable · d0b9112f
  Lin Jen-Shin authored Jul 12, 2016
  
  d0b9112f
- Could be faster when params[:path] is missing · 57c72cb0
  Lin Jen-Shin authored Jul 12, 2016
  
  57c72cb0
- Add all the tests and fix stuffs along the way: · e3832540
  Lin Jen-Shin authored Jul 12, 2016
```
It turns out they are different:

    builds.success.latest.first

and

    builds.latest.success.first

If we put success first, that latest would also filter via success,
and which is what we want here.
```
  e3832540
- Make rubocop happy · a96e9aa0
  Lin Jen-Shin authored Jul 12, 2016
  
  a96e9aa0
- Prefer if over return · c94cff3e
  Lin Jen-Shin authored Jul 12, 2016
  
  c94cff3e
- Prefer empty relation rather than arrays · 6597c213
  Lin Jen-Shin authored Jul 12, 2016
  
  6597c213
- Doh. I already wrote that test and I forgot. · a1eac5e4
  Lin Jen-Shin authored Jul 12, 2016
  
  a1eac5e4
- Conforming the style · 9604f123
  Lin Jen-Shin authored Jul 12, 2016
  
  9604f123