1. 05 Jun, 2013 2 commits
    • Kazuhiko Shiozaki's avatar
      respect user's input for source or destionation in Base_addEvent. · 61e73e83
      Kazuhiko Shiozaki authored
      before, user's input is completely ignored and calculated good values
      are automatically set. and the commit fc54fbaa somehow tried to
      respect user's source input, but it caused worse result for incoming
      case. so this commit reverts fc54fbaa and set source and destination
      just as user's input if not empty.
      61e73e83
    • Arnaud Fontaine's avatar
      Avoid regeneration of classes when starting a node within a cluster with already started nodes. · 20362ede
      Arnaud Fontaine authored
      When starting a node, ERP5Site.__of__ calls ComponentTool.reset(), which was
      never synchronised so it returned True (without generating a new cookie at its
      level) and causing synchronizeDynamicModules to be called with
      force=True. This generated a new cookie and leading to dynamic classes being
      meaninglessly regenerated on all nodes.
      
      Instead, modify ComponentTool.reset() behavior so it *always* reset Portal
      Type classes when Components are reset (as it should have always been as the
      class inheritance may have been modified) and force regeneration of Portal
      Type classes in this method if reset is True.
      Signed-off-by: Vincent Pelletier's avatarVincent Pelletier <vincent@nexedi.com>
      20362ede
  2. 04 Jun, 2013 6 commits
    • Julien Muchembled's avatar
    • Vincent Pelletier's avatar
      Drop unneeded criterion. · 0d2e4dd6
      Vincent Pelletier authored
      0d2e4dd6
    • Vincent Pelletier's avatar
      Use REPLACE rather than INSERT for DELETE..INSERT indexation pattern. · 5d3ea021
      Vincent Pelletier authored
      When a document gets rows inserted in category table while there was none
      before (typically: first document indexation), it may trigger
        IntegrityError: (1062, "Duplicate entry '...' for key 'PRIMARY'")
      because in the DELETE..INSERT pattern, DELETE finds no matching rows and
      does not gap-lock (because we enable innodb_locks_unsafe_for_binlog), then
      the second INSERT happening, chronologically speaking, waits for the
      transaction of the first to e committed, and on commit it causes such
      duplicate key error.
      
      A transient visible effect of this change is that if both competing
      indexations see a different document state (because document got modified
      in some 3rd transaction), the union of the resulting set of rows will be
      visible until the reindexation which must have been triggered by the 3rd
      transaction gets executed, at which point only the latest set will be
      visible.
      
      A similar issue exists before this change, with stricter conditions: it
      needs the intersection of both sets to be empty, because a non-empty
      intersection causes the duplicate key error solved here.
      
      This change has been measured to improve scalability of an invoice building
      test case (naturally triggering indexations) starting from ~12 activity
      nodes:
         8 nodes:  +1.4% invoices/hour
        12 nodes:  +9.5% invoices/hour
        16 nodes: +12.3% invoices/hour
      (values are the difference between DELETE..INSERT and DELETE..REPLACE)
      5d3ea021
    • Julien Muchembled's avatar
      ZSQLCatalog: fix identation in EntireQuery · 4ec66892
      Julien Muchembled authored
      asSQLExpression() failed when executed several times on the same instance,
      because too much code was skipped when 'column_map' is cached.
      4ec66892
    • Vincent Pelletier's avatar
      Setter argument is required. · a5535be1
      Vincent Pelletier authored
      a5535be1
    • Julien Muchembled's avatar
      0eb3c1e8
  3. 03 Jun, 2013 1 commit
  4. 31 May, 2013 1 commit
  5. 30 May, 2013 1 commit
  6. 29 May, 2013 3 commits
  7. 28 May, 2013 2 commits
  8. 27 May, 2013 5 commits
  9. 24 May, 2013 4 commits
  10. 23 May, 2013 6 commits
  11. 22 May, 2013 2 commits
  12. 21 May, 2013 7 commits