- 14 Apr, 2021 8 commits
-
-
Arnaud Fontaine authored
ERP5Workflow: erp5_configurator_*: Migrate Configurator Workflows from workflow_module to portal_workflow (!1378).
-
Arnaud Fontaine authored
This also moves all Configurator Workflows in workflow_module to portal_workflow (workflow_module was an implementation of Workflows based on ERP5 objects and not using DCWorkflow code). * Workflows are now defined on on portal_workflow._chains_by_type anymore but, as everything else, on the Portal Type itself. * portal_workflow can contain and work at the same time with legacy and new Workflows (ERP5Type/patches/DCWorkflow.py monkey-patching DCWorkflow classes to provide the same API). * Existing Workflow Scripts should work as they are and the code can be updated later on to take advantage of the new API: + With legacy implementation Workflow {Scripts,Transitions,Worklists,States} were in a Folder ({scripts,transitions,worklists,states} attribute) but all of these are now in the Workflow itself and their IDs are prefixed (PropertySheet-style), for example `script_`. Legacy attributes are provided in new implementation to call the new API. + When calling a Workflow Script, `container` was bound to its parent, namely WF.scripts (Folder) and a Workflow Script could call another. Now `container` is bound to the WF itself and Workflow Scripts are in a Workflow directly. New implementation `scripts` attribute handle such use case. + Override portal_workflow.__getattr__ so that a Workflow Script can call another one without prefix. erp5_performance_test:testWorkflowPerformance were ran to compare DCWorkflow and ERP5Workflow implementations and it seems to be about 4% slower with the new implementation (legacy: 7.547, 7.593, 7.618, 7.59, 7.514 and new: 7.842, 7.723, 7.902, 7.837, 7.875). Work done by Wenjie Zheng, Isabelle Vallet, Sebastien Robin and myself.
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Jérome Perrin authored
-
Jérome Perrin authored
because this business template uses fields from erp5_trade field libraries
-
Jérome Perrin authored
-
Jérome Perrin authored
These fields were created when proxify action was broken. This re-exports the fields after using fixConsistency on them. see also !1352
-
- 13 Apr, 2021 6 commits
-
-
Kazuhiko Shiozaki authored
also add rel="noopener noreferrer" for security.
-
Kazuhiko Shiozaki authored
-
Vincent Pelletier authored
It seems this workfliow was created by copy-pasting event_workflow, without cleaning these variables up: they are used by a transition dialog on event_workflow but nothing on this workflow. Still, they are stored on every single document on every single transition, wasting resources. So remove them.
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
-
Kazuhiko Shiozaki authored
erp5_jquery_sheet_editor: unset Accelerated HTTP Cache Manager configuration in intermediate template.
-
- 12 Apr, 2021 3 commits
-
-
Kazuhiko Shiozaki authored
-
Vincent Pelletier authored
-
Jérome Perrin authored
-
- 09 Apr, 2021 4 commits
-
-
Nicolas Wavrant authored
See merge request !1385
-
Nicolas Wavrant authored
-
Nicolas Wavrant authored
So different test suites can have a same named sequence without theme colliding with each other
-
Nicolas Wavrant authored
-
- 07 Apr, 2021 1 commit
-
-
Arnaud Fontaine authored
-
- 06 Apr, 2021 1 commit
-
-
Jérome Perrin authored
-
- 02 Apr, 2021 2 commits
-
-
Jérome Perrin authored
When installing the tested software failed, no test result lines have been created, this should have status FAILED.
-
Jérome Perrin authored
person reference contained the username, so test was also passing, but what we really want to test is that the username is in the mail body.
-
- 01 Apr, 2021 1 commit
-
-
Jérome Perrin authored
ee64d50c (patches/CookieCrumbler: update patch for CMF 2.3, 2019-09-09) introduced a NameError, getRequest was not imported.
-
- 31 Mar, 2021 3 commits
-
-
Jérome Perrin authored
All reports were properly including movements from the last day, except general ledger which were only including movements made without hours:minutes (at midnight). This was not a problem for manually entered transactions, which are usually made at 00:00 but when transactions are entered with hour:minutes they were not included.
-
Nicolas Wavrant authored
-
Jérome Perrin authored
BMP are not compressed and use more disk space than PNG. The trick is that ERP5 uses by default a quality of 75% on images ([this is default on propertysheet]) so we need to dump the image with maximum (100%) quality. Update also assertion message to not include the full base64 image in case of difference, use a short assertion message and save images in log folder. [this is default on propertysheet]: https://lab.nexedi.com/nexedi/erp5/blob/2f9b67fae3ac59955231d4191a34134ff1b6079a/product/ERP5/bootstrap/erp5_property_sheets/PropertySheetTemplateItem/portal_property_sheets/HtmlStylePreference/preferred_image_quality_property.xml#L56
-
- 30 Mar, 2021 1 commit
-
-
Jérome Perrin authored
When rendering reports, deferred style was only keeping request.other, but some places, like Products.ERP5Form.ListBox.ListBox.getParamDict read only in request.form, which caused different behaviours when rendering reports directly or in activities, because when rendering in activities request keys that the report dialog might have pushed were not preset in request. They were of course present when rendering the report directly, because this was the same request, so this lead to different behaviours wether reports were rendering in activities or directly, like we could observe in 7058ab6f (accounting: fix grouping option of GL when running in deferred mode, 2021-02-25) This change deferred style to properly propagate request.other and request.form in all activities of reports.
-
- 29 Mar, 2021 9 commits
-
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
-
Gabriel Monnerat authored
Calculate link to allow Nexedi developers access the ERP5 fields, forms and form actions from it. * erp5 form gadget handle links to access from and form action * label field gadget handle links to access field configuration, title and descriptions translations * page action handle all links to access workflows and portal type document * add generic function to merge action with raw actions by group * Add sample of action that allow uses access slideshow from ERP5JS
-
Jérome Perrin authored
ERP5 uses a mix of context.REQUEST and Products.ERP5Type.Global.get_request(), which now uses zope.globalrequest.getRequest(). CMFActivity reconstruct the original request before executing activity, so that the activity is executed with a request equivalent to the request at the time where the method was activated. For this, context.REQUEST was properly restored, but get_request()/globalrequest was only restored when the REQUEST had some Accept-Language header, so that it replays the language negociation for Localizer. With browser requests, I guess every browser pass an Accept-Language header ( according to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Accept-Language all major browser support it), but within unit tests such header is not present. So this lead to activities with unit test requests being slightly different, because as they don't have Accept-Language, context.REQUEST was set, but the global request was not set, so they were running with two different requests in context.REQUEST and global request, leading to some problems for example with formulator fields.
-
Jérome Perrin authored
See merge request nexedi/erp5!1357
-
Georgios Dagkakis authored
-
- 26 Mar, 2021 1 commit
-
-
Georgios Dagkakis authored
See merge request nexedi/erp5!1381
-