Commit 4991d702 authored by Matt Holt's avatar Matt Holt Committed by GitHub

Merge pull request #1781 from mholt/global-fallback-hosts

httpserver: Add global FallbackHosts for vhost matching
parents 76a28271 c8307409
...@@ -45,6 +45,12 @@ func (t *vhostTrie) insertPath(remainingPath, originalPath string, site *SiteCon ...@@ -45,6 +45,12 @@ func (t *vhostTrie) insertPath(remainingPath, originalPath string, site *SiteCon
t.edges[ch].insertPath(remainingPath[1:], originalPath, site) t.edges[ch].insertPath(remainingPath[1:], originalPath, site)
} }
// When matching a site, the given host will be tried first.
// Then, FallbackHosts will be tried in order.
// Default FallbackHosts are following wildcards,
// which could be modified by plugins and directives.
var FallbackHosts = []string{"0.0.0.0", ""}
// Match returns the virtual host (site) in v with // Match returns the virtual host (site) in v with
// the closest match to key. If there was a match, // the closest match to key. If there was a match,
// it returns the SiteConfig and the path portion of // it returns the SiteConfig and the path portion of
...@@ -57,13 +63,13 @@ func (t *vhostTrie) insertPath(remainingPath, originalPath string, site *SiteCon ...@@ -57,13 +63,13 @@ func (t *vhostTrie) insertPath(remainingPath, originalPath string, site *SiteCon
// A typical key will be in the form "host" or "host/path". // A typical key will be in the form "host" or "host/path".
func (t *vhostTrie) Match(key string) (*SiteConfig, string) { func (t *vhostTrie) Match(key string) (*SiteConfig, string) {
host, path := t.splitHostPath(key) host, path := t.splitHostPath(key)
// try the given host, then, if no match, try wildcard hosts // try the given host, then, if no match, try fallback hosts
branch := t.matchHost(host) branch := t.matchHost(host)
if branch == nil { for _, h := range FallbackHosts {
branch = t.matchHost("0.0.0.0") if branch != nil {
} break
if branch == nil { }
branch = t.matchHost("") branch = t.matchHost(h)
} }
if branch == nil { if branch == nil {
return nil, "" return nil, ""
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment