Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
caddy
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
Łukasz Nowak
caddy
Commits
be2f5c4b
Commit
be2f5c4b
authored
Dec 31, 2015
by
Abiola Ibrahim
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Support for 4xx status codes.
parent
281007c4
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
83 additions
and
5 deletions
+83
-5
caddy/setup/rewrite.go
caddy/setup/rewrite.go
+13
-3
caddy/setup/rewrite_test.go
caddy/setup/rewrite_test.go
+27
-0
middleware/rewrite/rewrite.go
middleware/rewrite/rewrite.go
+13
-1
middleware/rewrite/rewrite_test.go
middleware/rewrite/rewrite_test.go
+30
-1
No files found.
caddy/setup/rewrite.go
View file @
be2f5c4b
...
@@ -2,6 +2,7 @@ package setup
...
@@ -2,6 +2,7 @@ package setup
import
(
import
(
"net/http"
"net/http"
"strconv"
"strings"
"strings"
"github.com/mholt/caddy/middleware"
"github.com/mholt/caddy/middleware"
...
@@ -33,6 +34,7 @@ func rewriteParse(c *Controller) ([]rewrite.Rule, error) {
...
@@ -33,6 +34,7 @@ func rewriteParse(c *Controller) ([]rewrite.Rule, error) {
var
err
error
var
err
error
var
base
=
"/"
var
base
=
"/"
var
pattern
,
to
string
var
pattern
,
to
string
var
status
int
var
ext
[]
string
var
ext
[]
string
args
:=
c
.
RemainingArgs
()
args
:=
c
.
RemainingArgs
()
...
@@ -73,15 +75,23 @@ func rewriteParse(c *Controller) ([]rewrite.Rule, error) {
...
@@ -73,15 +75,23 @@ func rewriteParse(c *Controller) ([]rewrite.Rule, error) {
return
nil
,
err
return
nil
,
err
}
}
ifs
=
append
(
ifs
,
ifCond
)
ifs
=
append
(
ifs
,
ifCond
)
case
"status"
:
if
!
c
.
NextArg
()
{
return
nil
,
c
.
ArgErr
()
}
status
,
_
=
strconv
.
Atoi
(
c
.
Val
())
if
status
<
400
||
status
>
499
{
return
nil
,
c
.
Err
(
"status must be 4xx"
)
}
default
:
default
:
return
nil
,
c
.
ArgErr
()
return
nil
,
c
.
ArgErr
()
}
}
}
}
// ensure to is specified
// ensure to
or status
is specified
if
to
==
""
{
if
to
==
""
&&
status
==
0
{
return
nil
,
c
.
ArgErr
()
return
nil
,
c
.
ArgErr
()
}
}
if
rule
,
err
=
rewrite
.
NewComplexRule
(
base
,
pattern
,
to
,
ext
,
ifs
);
err
!=
nil
{
if
rule
,
err
=
rewrite
.
NewComplexRule
(
base
,
pattern
,
to
,
status
,
ext
,
ifs
);
err
!=
nil
{
return
nil
,
err
return
nil
,
err
}
}
regexpRules
=
append
(
regexpRules
,
rule
)
regexpRules
=
append
(
regexpRules
,
rule
)
...
...
caddy/setup/rewrite_test.go
View file @
be2f5c4b
...
@@ -137,6 +137,33 @@ func TestRewriteParse(t *testing.T) {
...
@@ -137,6 +137,33 @@ func TestRewriteParse(t *testing.T) {
}`
,
false
,
[]
rewrite
.
Rule
{
}`
,
false
,
[]
rewrite
.
Rule
{
&
rewrite
.
ComplexRule
{
Base
:
"/"
,
To
:
"/to"
,
Ifs
:
[]
rewrite
.
If
{
rewrite
.
If
{
A
:
"{path}"
,
Operator
:
"is"
,
B
:
"a"
}}},
&
rewrite
.
ComplexRule
{
Base
:
"/"
,
To
:
"/to"
,
Ifs
:
[]
rewrite
.
If
{
rewrite
.
If
{
A
:
"{path}"
,
Operator
:
"is"
,
B
:
"a"
}}},
}},
}},
{
`rewrite {
status 400
}`
,
false
,
[]
rewrite
.
Rule
{
&
rewrite
.
ComplexRule
{
Base
:
"/"
,
Regexp
:
regexp
.
MustCompile
(
".*"
),
Status
:
400
},
}},
{
`rewrite {
to /to
status 400
}`
,
false
,
[]
rewrite
.
Rule
{
&
rewrite
.
ComplexRule
{
Base
:
"/"
,
To
:
"/to"
,
Regexp
:
regexp
.
MustCompile
(
".*"
),
Status
:
400
},
}},
{
`rewrite {
status 399
}`
,
true
,
[]
rewrite
.
Rule
{
&
rewrite
.
ComplexRule
{},
}},
{
`rewrite {
status 0
}`
,
true
,
[]
rewrite
.
Rule
{
&
rewrite
.
ComplexRule
{},
}},
{
`rewrite {
to /to
status 0
}`
,
true
,
[]
rewrite
.
Rule
{
&
rewrite
.
ComplexRule
{},
}},
}
}
for
i
,
test
:=
range
regexpTests
{
for
i
,
test
:=
range
regexpTests
{
...
...
middleware/rewrite/rewrite.go
View file @
be2f5c4b
...
@@ -24,6 +24,13 @@ type Rewrite struct {
...
@@ -24,6 +24,13 @@ type Rewrite struct {
func
(
rw
Rewrite
)
ServeHTTP
(
w
http
.
ResponseWriter
,
r
*
http
.
Request
)
(
int
,
error
)
{
func
(
rw
Rewrite
)
ServeHTTP
(
w
http
.
ResponseWriter
,
r
*
http
.
Request
)
(
int
,
error
)
{
for
_
,
rule
:=
range
rw
.
Rules
{
for
_
,
rule
:=
range
rw
.
Rules
{
if
ok
:=
rule
.
Rewrite
(
rw
.
FileSys
,
r
);
ok
{
if
ok
:=
rule
.
Rewrite
(
rw
.
FileSys
,
r
);
ok
{
// if rule is complex rule and status code is set
if
cRule
,
ok
:=
rule
.
(
*
ComplexRule
);
ok
&&
cRule
.
Status
!=
0
{
return
cRule
.
Status
,
nil
}
// rewrite done
break
break
}
}
}
}
...
@@ -67,6 +74,10 @@ type ComplexRule struct {
...
@@ -67,6 +74,10 @@ type ComplexRule struct {
// Path to rewrite to
// Path to rewrite to
To
string
To
string
// If set, neither performs rewrite nor proceeds
// with request. Only returns code.
Status
int
// Extensions to filter by
// Extensions to filter by
Exts
[]
string
Exts
[]
string
...
@@ -78,7 +89,7 @@ type ComplexRule struct {
...
@@ -78,7 +89,7 @@ type ComplexRule struct {
// NewRegexpRule creates a new RegexpRule. It returns an error if regexp
// NewRegexpRule creates a new RegexpRule. It returns an error if regexp
// pattern (pattern) or extensions (ext) are invalid.
// pattern (pattern) or extensions (ext) are invalid.
func
NewComplexRule
(
base
,
pattern
,
to
string
,
ext
[]
string
,
ifs
[]
If
)
(
*
ComplexRule
,
error
)
{
func
NewComplexRule
(
base
,
pattern
,
to
string
,
status
int
,
ext
[]
string
,
ifs
[]
If
)
(
*
ComplexRule
,
error
)
{
// validate regexp if present
// validate regexp if present
var
r
*
regexp
.
Regexp
var
r
*
regexp
.
Regexp
if
pattern
!=
""
{
if
pattern
!=
""
{
...
@@ -102,6 +113,7 @@ func NewComplexRule(base, pattern, to string, ext []string, ifs []If) (*ComplexR
...
@@ -102,6 +113,7 @@ func NewComplexRule(base, pattern, to string, ext []string, ifs []If) (*ComplexR
return
&
ComplexRule
{
return
&
ComplexRule
{
Base
:
base
,
Base
:
base
,
To
:
to
,
To
:
to
,
Status
:
status
,
Exts
:
ext
,
Exts
:
ext
,
Ifs
:
ifs
,
Ifs
:
ifs
,
Regexp
:
r
,
Regexp
:
r
,
...
...
middleware/rewrite/rewrite_test.go
View file @
be2f5c4b
...
@@ -41,7 +41,7 @@ func TestRewrite(t *testing.T) {
...
@@ -41,7 +41,7 @@ func TestRewrite(t *testing.T) {
if
s
:=
strings
.
Split
(
regexpRule
[
3
],
"|"
);
len
(
s
)
>
1
{
if
s
:=
strings
.
Split
(
regexpRule
[
3
],
"|"
);
len
(
s
)
>
1
{
ext
=
s
[
:
len
(
s
)
-
1
]
ext
=
s
[
:
len
(
s
)
-
1
]
}
}
rule
,
err
:=
NewComplexRule
(
regexpRule
[
0
],
regexpRule
[
1
],
regexpRule
[
2
],
ext
,
nil
)
rule
,
err
:=
NewComplexRule
(
regexpRule
[
0
],
regexpRule
[
1
],
regexpRule
[
2
],
0
,
ext
,
nil
)
if
err
!=
nil
{
if
err
!=
nil
{
t
.
Fatal
(
err
)
t
.
Fatal
(
err
)
}
}
...
@@ -106,6 +106,35 @@ func TestRewrite(t *testing.T) {
...
@@ -106,6 +106,35 @@ func TestRewrite(t *testing.T) {
i
,
test
.
expectedTo
,
rec
.
Body
.
String
())
i
,
test
.
expectedTo
,
rec
.
Body
.
String
())
}
}
}
}
statusTests
:=
[]
int
{
401
,
405
,
403
,
400
,
}
for
i
,
s
:=
range
statusTests
{
urlPath
:=
fmt
.
Sprintf
(
"/status%d"
,
i
)
rule
,
err
:=
NewComplexRule
(
urlPath
,
""
,
""
,
s
,
nil
,
nil
)
if
err
!=
nil
{
t
.
Fatalf
(
"Test %d: No error expected for rule but found %v"
,
i
,
err
)
}
rw
.
Rules
=
append
(
rw
.
Rules
,
rule
)
req
,
err
:=
http
.
NewRequest
(
"GET"
,
urlPath
,
nil
)
if
err
!=
nil
{
t
.
Fatalf
(
"Test %d: Could not create HTTP request: %v"
,
i
,
err
)
}
rec
:=
httptest
.
NewRecorder
()
code
,
err
:=
rw
.
ServeHTTP
(
rec
,
req
)
if
err
!=
nil
{
t
.
Fatalf
(
"Test %d: No error expected for handler but found %v"
,
i
,
err
)
}
if
rec
.
Body
.
String
()
!=
""
{
t
.
Errorf
(
"Test %d: Expected empty body but found %s"
,
i
,
rec
.
Body
.
String
())
}
if
code
!=
s
{
t
.
Errorf
(
"Text %d: Expected status code %d found %d"
,
i
,
s
,
code
)
}
}
}
}
func
urlPrinter
(
w
http
.
ResponseWriter
,
r
*
http
.
Request
)
(
int
,
error
)
{
func
urlPrinter
(
w
http
.
ResponseWriter
,
r
*
http
.
Request
)
(
int
,
error
)
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment