1. 02 Aug, 2016 1 commit
    • Tw's avatar
      tls: fix TestStandaloneTLSTicketKeyRotation data race · 3d43c5b6
      Tw authored
      ==================
      WARNING: DATA RACE
      Write at 0x00c42049d300 by goroutine 26:
        github.com/mholt/caddy/caddytls.standaloneTLSTicketKeyRotation()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto.go:230 +0x698
      
      Previous read at 0x00c42049d300 by goroutine 25:
        github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:113 +0x413
        testing.tRunner()
            /home/tw/goroot/src/testing/testing.go:610 +0xc9
      
      Goroutine 26 (running) created at:
        github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:101 +0x2a4
        testing.tRunner()
            /home/tw/goroot/src/testing/testing.go:610 +0xc9
      
      Goroutine 25 (running) created at:
        testing.(*T).Run()
            /home/tw/goroot/src/testing/testing.go:646 +0x52f
        testing.RunTests.func1()
            /home/tw/goroot/src/testing/testing.go:793 +0xb9
        testing.tRunner()
            /home/tw/goroot/src/testing/testing.go:610 +0xc9
        testing.RunTests()
            /home/tw/goroot/src/testing/testing.go:799 +0x4b5
        testing.(*M).Run()
            /home/tw/goroot/src/testing/testing.go:743 +0x12f
        github.com/mholt/caddy/caddytls.TestMain()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/setup_test.go:27 +0x133
        main.main()
            github.com/mholt/caddy/caddytls/_test/_testmain.go:116 +0x1b1
      ==================
      ==================
      WARNING: DATA RACE
      Write at 0x00c4204aa6c0 by goroutine 26:
        github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation.func2()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:93 +0x56
        github.com/mholt/caddy/caddytls.standaloneTLSTicketKeyRotation()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto.go:233 +0x638
      
      Previous read at 0x00c4204aa6c0 by goroutine 25:
        github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:108 +0x391
        testing.tRunner()
            /home/tw/goroot/src/testing/testing.go:610 +0xc9
      
      Goroutine 26 (running) created at:
        github.com/mholt/caddy/caddytls.TestStandaloneTLSTicketKeyRotation()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/crypto_test.go:101 +0x2a4
        testing.tRunner()
            /home/tw/goroot/src/testing/testing.go:610 +0xc9
      
      Goroutine 25 (running) created at:
        testing.(*T).Run()
            /home/tw/goroot/src/testing/testing.go:646 +0x52f
        testing.RunTests.func1()
            /home/tw/goroot/src/testing/testing.go:793 +0xb9
        testing.tRunner()
            /home/tw/goroot/src/testing/testing.go:610 +0xc9
        testing.RunTests()
            /home/tw/goroot/src/testing/testing.go:799 +0x4b5
        testing.(*M).Run()
            /home/tw/goroot/src/testing/testing.go:743 +0x12f
        github.com/mholt/caddy/caddytls.TestMain()
            /home/tw/golib/src/github.com/mholt/caddy/caddytls/setup_test.go:27 +0x133
        main.main()
            github.com/mholt/caddy/caddytls/_test/_testmain.go:116 +0x1b1
      ==================
      Signed-off-by: default avatarTw <tw19881113@gmail.com>
      3d43c5b6
  2. 01 Aug, 2016 5 commits
  3. 30 Jul, 2016 1 commit
  4. 29 Jul, 2016 2 commits
  5. 28 Jul, 2016 2 commits
  6. 27 Jul, 2016 1 commit
  7. 25 Jul, 2016 1 commit
  8. 24 Jul, 2016 1 commit
    • Philipp Brüll's avatar
      Change position of locale directive · 1dd413bd
      Philipp Brüll authored
      First, great job on the 0.9 release! It seems caddy's path lead into a bright future. Thanks also for including the locale plugin.
      
      Trying it, I've figured out, that there might be a problem with the order of the directives. In the typical use case, the result of the locale detection might be used in the `rewrite` and `log` plugin. If I'm not mistaken, it makes sense to put the `locale` directive before those.
      1dd413bd
  9. 23 Jul, 2016 2 commits
  10. 22 Jul, 2016 2 commits
  11. 21 Jul, 2016 8 commits
  12. 19 Jul, 2016 7 commits
  13. 18 Jul, 2016 4 commits
  14. 16 Jul, 2016 1 commit
  15. 15 Jul, 2016 2 commits