1. 02 May, 2017 3 commits
    • Matt Holt's avatar
      httpserver/all: Clean up and standardize request URL handling (#1633) · d5371aff
      Matt Holt authored
      * httpserver/all: Clean up and standardize request URL handling
      
      The HTTP server now always creates a context value on the request which
      is a copy of the request's URL struct. It should not be modified by
      middlewares, but it is safe to get the value out of the request and make
      changes to it locally-scoped. Thus, the value in the context always
      stores the original request URL information as it was received. Any
      rewrites that happen will be to the request's URL field directly.
      
      The HTTP server no longer cleans /sanitizes the request URL. It made too
      many strong assumptions and ended up making a lot of middleware more
      complicated, including upstream proxying (and fastcgi). To alleviate
      this complexity, we no longer change the request URL. Middlewares are
      responsible to access the disk safely by using http.Dir or, if not
      actually opening files, they can use httpserver.SafePath().
      
      I'm hoping this will address issues with #1624, #1584, #1582, and others.
      
      * staticfiles: Fix test on Windows
      
      @abiosoft: I still can't figure out exactly what this is for. 😅
      
      * Use (potentially) changed URL for browse redirects, as before
      
      * Use filepath.ToSlash, clean up a couple proxy test cases
      
      * Oops, fix variable name
      d5371aff
    • Matt Holt's avatar
      Merge pull request #1642 from tw4452852/internal · 5685a164
      Matt Holt authored
      internal: inherit original ResponseWriter's interfaces
      5685a164
    • Tw's avatar
      internal: inherit original ResponseWriter's interfaces · f58653bc
      Tw authored
      Signed-off-by: default avatarTw <tw19881113@gmail.com>
      f58653bc
  2. 01 May, 2017 3 commits
  3. 30 Apr, 2017 5 commits
  4. 29 Apr, 2017 2 commits
  5. 27 Apr, 2017 1 commit
  6. 26 Apr, 2017 5 commits
  7. 25 Apr, 2017 2 commits
  8. 23 Apr, 2017 1 commit
  9. 22 Apr, 2017 3 commits
  10. 21 Apr, 2017 3 commits
  11. 20 Apr, 2017 3 commits
  12. 19 Apr, 2017 2 commits
  13. 18 Apr, 2017 7 commits