Commit 532feb88 authored by Rusty Russell's avatar Rusty Russell

tap: WANT_PTHREAD not HAVE_PTHREAD

I'm not sure that a "pthread-safe" tap library is very useful; how many
people have multiple threads calling ok()?

Kirill Shutemov noted that it gives a warning with -Wundef; indeed, we
should ask in this case whether they want pthread support, not whether the
system has pthread support to offer.
parent f4eb3a18
......@@ -45,8 +45,13 @@ static int test_died = 0;
static int test_pid;
/* Encapsulate the pthread code in a conditional. In the absence of
libpthread the code does nothing */
#if HAVE_LIBPTHREAD
libpthread the code does nothing.
If you have multiple threads calling ok() etc. at the same time you would
need this, but in that case your test numbers will be random and I'm not
sure it makes sense. --RR
*/
#ifdef WANT_PTHREAD
#include <pthread.h>
static pthread_mutex_t M = PTHREAD_MUTEX_INITIALIZER;
# define LOCK pthread_mutex_lock(&M)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment