Don't do pointer arithmetic on void*.

Reported by cppcheck. (portability) '(void*)((char*)current_attribute)' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined.

Don't do pointer arithmetic on void*.
Reported by cppcheck. (portability) '(void*)((char*)current_attribute)' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined.
0f90a538 · Antonin Décimo · Juliusz Chroboczek · 62186a37 · 0f90a538
Commit 0f90a538 authored Oct 24, 2018 by Antonin Décimo Committed by Juliusz Chroboczek Oct 25, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 3 deletions

kernel_netlink.c kernel_netlink.c +3 -3

No files found.
--- a/kernel_netlink.c
+++ b/kernel_netlink.c
@@ -1590,7 +1590,7 @@ add_rule(int prio, const unsigned char *src_prefix, int src_plen, int table)

    message_header->nlmsg_len += current_attribute->rta_len;
    current_attribute = (void*)
-        ((char*)current_attribute) + current_attribute->rta_len;
+        ((char*)current_attribute + current_attribute->rta_len);

    /* src */
    current_attribute->rta_len = RTA_LENGTH(addr_size);
@@ -1599,7 +1599,7 @@ add_rule(int prio, const unsigned char *src_prefix, int src_plen, int table)

    message_header->nlmsg_len += current_attribute->rta_len;
    current_attribute = (void*)
-        ((char*)current_attribute) + current_attribute->rta_len;
+        ((char*)current_attribute + current_attribute->rta_len);

    /* send message */
    if(message_header->nlmsg_len > 64) {
@@ -1652,7 +1652,7 @@ flush_rule(int prio, int family)

    message_header->nlmsg_len += current_attribute->rta_len;
    current_attribute = (void*)
-        ((char*)current_attribute) + current_attribute->rta_len;
+        ((char*)current_attribute + current_attribute->rta_len);

    /* send message */
    if(message_header->nlmsg_len > 64) {