Commit e38921f4 authored by Tw's avatar Tw Committed by Matt Holt

httpserver: rename context Push action for more general use (#1641)

Signed-off-by: default avatarTw <tw19881113@gmail.com>
parent 8e7a36de
...@@ -424,12 +424,13 @@ func (c Context) RandomString(minLen, maxLen int) string { ...@@ -424,12 +424,13 @@ func (c Context) RandomString(minLen, maxLen int) string {
return string(result) return string(result)
} }
// Push adds a preload link in response header for server push // AddLink adds a link header in response
func (c Context) Push(link string) string { // see https://www.w3.org/wiki/LinkHeader
func (c Context) AddLink(link string) string {
if c.responseHeader == nil { if c.responseHeader == nil {
return "" return ""
} }
c.responseHeader.Add("Link", "<"+link+">; rel=preload") c.responseHeader.Add("Link", link)
return "" return ""
} }
......
...@@ -877,18 +877,18 @@ func TestFiles(t *testing.T) { ...@@ -877,18 +877,18 @@ func TestFiles(t *testing.T) {
} }
} }
func TestPush(t *testing.T) { func TestAddLink(t *testing.T) {
for name, c := range map[string]struct { for name, c := range map[string]struct {
input string input string
expectLinks []string expectLinks []string
}{ }{
"oneLink": { "oneLink": {
input: `{{.Push "/test.css"}}`, input: `{{.AddLink "</test.css>; rel=preload"}}`,
expectLinks: []string{"</test.css>; rel=preload"}, expectLinks: []string{"</test.css>; rel=preload"},
}, },
"multipleLinks": { "multipleLinks": {
input: `{{.Push "/test1.css"}} {{.Push "/test2.css"}}`, input: `{{.AddLink "</test1.css>; rel=preload"}} {{.AddLink "</test2.css>; rel=meta"}}`,
expectLinks: []string{"</test1.css>; rel=preload", "</test2.css>; rel=preload"}, expectLinks: []string{"</test1.css>; rel=preload", "</test2.css>; rel=meta"},
}, },
} { } {
c := c c := c
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment