1. 19 Oct, 2015 2 commits
  2. 18 Oct, 2015 10 commits
  3. 17 Oct, 2015 7 commits
  4. 16 Oct, 2015 5 commits
  5. 15 Oct, 2015 5 commits
    • Matthew Holt's avatar
      OncePerServerBlock may now return an error · 691204ce
      Matthew Holt authored
      691204ce
    • Matthew Holt's avatar
      Merge branch 'master' into configfix · a518049f
      Matthew Holt authored
      a518049f
    • Matthew Holt's avatar
      First use of OncePerServerBlock in a Setup function · 35e309cf
      Matthew Holt authored
      startup and shutdown commands should only be executed once per appearance in the Caddyfile (naturally meaning once per server block).
      
      Notice that we support multiple occurrences of startup and shutdown in the same server block by building the callback array incrementally as we parse the Caddyfile, then we append all the callbacks all at once. Quite literally, the OncePerServerBlock function executes only once per server block!
      35e309cf
    • Matthew Holt's avatar
      Don't share sync.Once with all directives · e0fdddc7
      Matthew Holt authored
      If each server block had only one sync.Once then all directives would refer to it and only the first directive would be able to use it! So this commit changes it to a map of sync.Once instances, keyed by directive. So by creating a new map for every server block, each directive in that block can get its own sync.Once which is exactly what is needed. They won't step on each other this way.
      e0fdddc7
    • Matthew Holt's avatar
      Epic revert of 0ac8bf58 and adding OncePerServerBlock · 0c07f7ad
      Matthew Holt authored
      Turns out having each server block share a single server.Config during initialization when the Setup functions are being called was a bad idea. Sure, startup and shutdown functions were only executed once, but they had no idea what their hostname or port was. So here we revert to the old way of doing things where Setup may be called multiple times per server block (once per host associated with the block, to be precise), but the Setup functions now know their host and port since the config belongs to exactly one virtualHost. To have something happen just once per server block, use OncePerServerBlock, a new function available on each Controller.
      0c07f7ad
  6. 14 Oct, 2015 9 commits
  7. 13 Oct, 2015 2 commits
    • Zac Bergquist's avatar
      Fix test failures on Windows. · e158cda0
      Zac Bergquist authored
      Most of the Windows test failures are due to the path separator not being "/".  The general approach I took here was to keep paths in "URL form" (ie using "/" separators) as much as possible, and only convert to native paths when we attempt to open a file.  This will allow the most consistency between different host OS.  For example, data structures that store paths still store them with "/" delimiters.  Functions that accepted paths as input and return them as outputs still use "/".
      
      There are still a few test failures that need to be sorted out.
      
      - config/setup/TestRoot (I hear this has already been fixed by someone else)
      - middleware/basicauth/TestBrowseTemplate and middleware/templates/Test (a line endings issue that I'm still working through)
      e158cda0
    • Matthew Holt's avatar
      7121e2c7