1. 28 Apr, 2021 1 commit
    • Jérome Perrin's avatar
      openoffice: fix psutil usage in _releaseOpenOfficePort · 0b5ff71a
      Jérome Perrin authored
      This uses psutil.process_iter to iterate on all processes, but in the meantime
      some process might terminate.
      
      As we could observe in the logs:
      
          2021-04-26 12:53:02 - Cloudooo - DEBUG - Stop Pid - 15816
          Exception in thread Thread-1:
          Traceback (most recent call last):
            File "python2.7/lib/python2.7/threading.py", line 801, in __bootstrap_inner
              self.run()
            File "cloudooo-repository/cloudooo/handler/ooo/monitor/request.py", line 60, in run
              self.openoffice.restart()
            File "cloudooo-repository/cloudooo/handler/ooo/application/application.py", line 79, in restart
              self.stop()
            File "cloudooo-repository/cloudooo/handler/ooo/application/openoffice.py", line 169, in stop
              self._releaseOpenOfficePort()
            File "cloudooo-repository/cloudooo/handler/ooo/application/openoffice.py", line 122, in _releaseOpenOfficePort
              if process.exe() == join(self.office_binary_path, self._bin_soffice):
            File "psutil-5.8.0-py2.7-linux-x86_64.egg/psutil/__init__.py", line 660, in exe
              exe = self._proc.exe()
            File "psutil-5.8.0-py2.7-linux-x86_64.egg/psutil/_pslinux.py", line 1688, in exe
              raise NoSuchProcess(self.pid, self._name)
          NoSuchProcess: psutil.NoSuchProcess process no longer exists (pid=19382)
      
      Update to catch and ignore such exceptions, and minor refactorings such as:
       - Not calculate the path of openoffice binary in the loop, this is not
         supposed to change.
       - Remove reference to lsof in logged message, this does not use lsof.
       - Catch all exceptions.
      0b5ff71a
  2. 29 Mar, 2021 1 commit
    • Jérome Perrin's avatar
      manager/getAllowedExtensionList: use explicit extensions in ERP5 legacy mode · be6c35c0
      Jérome Perrin authored
      In python2, mimetypes module was not deterministic and this snippet:
      
          import mimetypes; print(mimetypes.guess_extension("text/html"))
      
      use to be ".html" on python 2.7.14, but is ".htm" on python 2.7.18
      
      Similarly:
      
          import mimetypes; print(mimetypes.guess_extension("application/msword"))
      
      was ".doc" on 2.7.14 and ".dot" on 2.7.18 (this was in my observations, this
      does not look deterministic as it is iterating on a dict, maybe this behaviour
      is not always same)
      
      For html conversion engine, ERP5 expect that the extension for text/html is
      .html, not .htm. Some tests also expect that the conversion for word is .doc so
      to keep compatibility with extensions used in ERP5 compatibility mode, define
      explicitly these two extensions instead of depending on python standard library.
      be6c35c0
  3. 01 Jun, 2020 1 commit
  4. 25 May, 2020 1 commit
  5. 18 May, 2020 1 commit
  6. 14 May, 2020 1 commit
  7. 06 May, 2020 1 commit
  8. 05 May, 2020 1 commit
  9. 02 Jan, 2020 1 commit
  10. 30 Dec, 2019 1 commit
  11. 27 Dec, 2019 1 commit
  12. 13 Mar, 2019 1 commit
  13. 21 Sep, 2018 1 commit
  14. 18 Sep, 2018 3 commits
  15. 14 Sep, 2018 4 commits
  16. 03 Aug, 2018 1 commit
  17. 26 Feb, 2018 9 commits
  18. 19 Feb, 2018 1 commit
  19. 21 Feb, 2017 1 commit
  20. 17 Jan, 2017 1 commit
  21. 14 Jan, 2017 1 commit
  22. 13 Jan, 2017 3 commits
  23. 05 Jan, 2017 1 commit
  24. 03 Jan, 2017 2 commits