Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in / Register
  • cloudooo cloudooo
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • nexedi
  • cloudooocloudooo
  • Merge requests
  • !40

Open
Created Jan 27, 2026 by Jérome Perrin@jeromeOwner
  • Report abuse
Report abuse

wkhtmltopdf: do not check return code of wkhtmltopdf

  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 4

This partially reverts dd792169 (wkhtmltopdf: Improve error reporting, 2025-12-05), because ERP5 test suite revealed some usages where wkhtmltopdf process exits with a non-zero return code, for example when converting an html file referencing images as relative paths. Converting html with such images try to open local files, that are blocked because we use --disable-local-file-access, but this apparently affects the return code of wkhtmltopdf.

This also fixes testWkhtmltopdfServer so that it actually uses wkhtmltopdf.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix/wkhtml_check_subprocess
GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7