Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
converse.js
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
converse.js
Commits
1de2f714
Commit
1de2f714
authored
Oct 18, 2016
by
JC Brand
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Let bookmarks list use same markup/css as the available rooms list
parent
623c56c8
Changes
7
Hide whitespace changes
Inline
Side-by-side
Showing
7 changed files
with
48 additions
and
59 deletions
+48
-59
css/converse.css
css/converse.css
+19
-27
sass/_bookmarks.scss
sass/_bookmarks.scss
+21
-23
sass/_controlbox.scss
sass/_controlbox.scss
+2
-3
spec/bookmarks.js
spec/bookmarks.js
+2
-2
src/templates/bookmark.html
src/templates/bookmark.html
+2
-2
src/templates/bookmarks_list.html
src/templates/bookmarks_list.html
+1
-1
src/templates/room_panel.html
src/templates/room_panel.html
+1
-1
No files found.
css/converse.css
View file @
1de2f714
...
@@ -1614,18 +1614,18 @@
...
@@ -1614,18 +1614,18 @@
#conversejs
#controlbox
#chatrooms
form
.add-chatroom
input
[
type
=
submit
],
#conversejs
#controlbox
#chatrooms
form
.add-chatroom
input
[
type
=
submit
],
#conversejs
#controlbox
#chatrooms
form
.add-chatroom
input
[
type
=
text
]
{
#conversejs
#controlbox
#chatrooms
form
.add-chatroom
input
[
type
=
text
]
{
width
:
100%
;
}
width
:
100%
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
{
margin
:
0
1em
;
margin
:
0
1em
;
padding
:
0
;
padding
:
0
;
text-align
:
left
;
}
text-align
:
left
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dt
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dt
{
border
:
none
;
border
:
none
;
color
:
#818479
;
color
:
#818479
;
font-weight
:
normal
;
font-weight
:
normal
;
padding
:
0
;
padding
:
0
;
padding-bottom
:
0.5em
;
padding-bottom
:
0.5em
;
text-shadow
:
0
1px
0
#FAFAFA
;
}
text-shadow
:
0
1px
0
#FAFAFA
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
{
border
:
none
;
border
:
none
;
clear
:
both
;
clear
:
both
;
color
:
#818479
;
color
:
#818479
;
...
@@ -1634,30 +1634,29 @@
...
@@ -1634,30 +1634,29 @@
padding
:
0.4em
;
padding
:
0.4em
;
text-shadow
:
0
1px
0
#FAFAFA
;
text-shadow
:
0
1px
0
#FAFAFA
;
word-wrap
:
break-word
;
}
word-wrap
:
break-word
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
:hover
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
:hover
{
background-color
:
#DCF9F6
;
}
background-color
:
#DCF9F6
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
a
.room-info
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
a
.room-info
{
display
:
none
;
clear
:
right
;
clear
:
right
;
display
:
block
;
}
display
:
block
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
a
.room-info
:before
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
a
.room-info
:before
{
font-size
:
15px
;
}
font-size
:
15px
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
a
.open-room
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
a
.open-room
{
float
:
left
;
float
:
left
;
width
:
85%
;
}
width
:
85%
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
.room-info
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
.room-info
{
font-size
:
1
1
px
;
font-size
:
1
2
px
;
font-style
:
normal
;
font-style
:
normal
;
font-weight
:
normal
;
}
font-weight
:
normal
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
li
.room-info
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
li
.room-info
{
display
:
block
;
display
:
block
;
margin-left
:
5px
;
}
margin-left
:
5px
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
p
.room-info
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
p
.room-info
{
margin
:
0
;
margin
:
0
;
padding
:
0
;
padding
:
0
;
display
:
block
;
display
:
block
;
white-space
:
normal
;
}
white-space
:
normal
;
}
#conversejs
#controlbox
#chatrooms
#available-chatrooms
dd
.available-chatroom
div
.room-info
{
#conversejs
#controlbox
#chatrooms
dl
.rooms-list
dd
.available-chatroom
div
.room-info
{
clear
:
left
;
clear
:
left
;
width
:
100%
;
}
width
:
100%
;
}
#conversejs
#controlbox
.dropdown
{
#conversejs
#controlbox
.dropdown
{
...
@@ -2167,23 +2166,16 @@
...
@@ -2167,23 +2166,16 @@
right
:
116px
;
right
:
116px
;
bottom
:
10px
;
}
bottom
:
10px
;
}
#conversejs
#controlbox
.bookmarks-list
.bookmarks-toggle
{
#conversejs
#controlbox
#chatrooms
.bookmarks-list
.bookmarks-toggle
{
display
:
block
;
display
:
block
;
font-weight
:
bold
;
font-weight
:
bold
;
color
:
#818479
;
color
:
#818479
;
margin-bottom
:
0.5em
;
}
margin-bottom
:
0.5em
;
}
#conversejs
#controlbox
.bookmarks-list
.bookmarks
li
{
#conversejs
#controlbox
#chatrooms
.bookmarks-list
dl
.rooms-list.bookmarks
dd
.available-chatroom
a
.room-info
{
padding
:
0.1em
1em
;
}
clear
:
none
;
}
#conversejs
#controlbox
.bookmarks-list
.bookmarks
li
.open-room
{
#conversejs
#controlbox
#chatrooms
.bookmarks-list
dl
.rooms-list.bookmarks
dd
.available-chatroom
a
.open-room
{
display
:
inline-block
;
width
:
75%
;
}
overflow
:
hidden
;
#conversejs
#controlbox
#chatrooms
.bookmarks-list
dl
.rooms-list.bookmarks
dd
.available-chatroom
.remove-bookmark
{
white-space
:
nowrap
;
float
:
right
;
}
text-overflow
:
ellipsis
;
width
:
75%
;
text-align
:
left
;
}
#conversejs
#controlbox
.bookmarks-list
.bookmarks
li
.room-info
{
float
:
right
;
}
#conversejs
#controlbox
.bookmarks-list
.bookmarks
li
.remove-bookmark
{
float
:
right
;
}
/*# sourceMappingURL=converse.css.map */
/*# sourceMappingURL=converse.css.map */
sass/_bookmarks.scss
View file @
1de2f714
#conversejs
{
#conversejs
{
#controlbox
{
#controlbox
{
.bookmarks-list
{
#chatrooms
{
.bookmarks-toggle
{
.bookmarks-list
{
display
:
block
;
.bookmarks-toggle
{
font-weight
:
bold
;
display
:
block
;
color
:
$text-color
;
font-weight
:
bold
;
margin-bottom
:
0
.5em
;
color
:
$text-color
;
}
margin-bottom
:
0
.5em
;
.bookmarks
{
}
li
{
dl
.rooms-list.bookmarks
{
padding
:
0
.1em
1em
;
dd
.available-chatroom
{
.open-room
{
a
{
display
:
inline-block
;
&
.room-info
{
overflow
:
hidden
;
clear
:
none
;
white-space
:
nowrap
;
}
text-overflow
:
ellipsis
;
&
.open-room
{
width
:
75%
;
width
:
75%
;
text-align
:
left
;
}
}
}
.room-info
{
.remove-bookmark
{
float
:
right
;
float
:
right
;
}
}
.remove-bookmark
{
float
:
right
;
}
}
}
}
}
}
...
...
sass/_controlbox.scss
View file @
1de2f714
...
@@ -117,7 +117,7 @@
...
@@ -117,7 +117,7 @@
width
:
100%
;
width
:
100%
;
}
}
}
}
#available-chatrooms
{
dl
.rooms-list
{
margin
:
0
1em
;
margin
:
0
1em
;
padding
:
0
;
padding
:
0
;
text-align
:
left
;
text-align
:
left
;
...
@@ -143,7 +143,6 @@
...
@@ -143,7 +143,6 @@
}
}
a
{
a
{
&
.room-info
{
&
.room-info
{
display
:
none
;
clear
:
right
;
clear
:
right
;
display
:
block
;
display
:
block
;
&
:before
{
&
:before
{
...
@@ -156,7 +155,7 @@
...
@@ -156,7 +155,7 @@
}
}
}
}
.room-info
{
.room-info
{
font-size
:
11px
;
font-size
:
$font-size-small
;
font-style
:
normal
;
font-style
:
normal
;
font-weight
:
normal
;
font-weight
:
normal
;
}
}
...
...
spec/bookmarks.js
View file @
1de2f714
...
@@ -386,7 +386,7 @@
...
@@ -386,7 +386,7 @@
beforeEach
(
function
()
{
beforeEach
(
function
()
{
test_utils
.
openRoomsPanel
();
test_utils
.
openRoomsPanel
();
converse
.
bookmarks
.
reset
();
converse
.
bookmarks
.
reset
();
converse
.
chatboxviews
.
get
(
'
controlbox
'
).
$
(
'
#chatrooms
u
l.bookmarks
'
).
html
(
''
);
converse
.
chatboxviews
.
get
(
'
controlbox
'
).
$
(
'
#chatrooms
d
l.bookmarks
'
).
html
(
''
);
});
});
it
(
"
shows a list of bookmarks
"
,
function
()
{
it
(
"
shows a list of bookmarks
"
,
function
()
{
...
@@ -417,7 +417,7 @@
...
@@ -417,7 +417,7 @@
'
jid
'
:
'
another@conference.shakespeare.lit
'
'
jid
'
:
'
another@conference.shakespeare.lit
'
}).
c
(
'
nick
'
).
t
(
'
JC
'
).
up
().
up
();
}).
c
(
'
nick
'
).
t
(
'
JC
'
).
up
().
up
();
converse
.
connection
.
_dataRecv
(
test_utils
.
createRequest
(
stanza
));
converse
.
connection
.
_dataRecv
(
test_utils
.
createRequest
(
stanza
));
expect
(
$
(
'
#chatrooms
ul.bookmarks li
'
).
length
).
toBe
(
3
);
expect
(
$
(
'
#chatrooms
dl.bookmarks dd
'
).
length
).
toBe
(
3
);
});
});
});
});
});
});
...
...
src/templates/bookmark.html
View file @
1de2f714
<
li
>
<
dd
class=
"available-chatroom"
>
<a
class=
"open-room"
data-room-jid=
"{{jid}}"
title=
"{{open_title}}"
href=
"#"
>
{{name}}
</a>
<a
class=
"open-room"
data-room-jid=
"{{jid}}"
title=
"{{open_title}}"
href=
"#"
>
{{name}}
</a>
<a
class=
"remove-bookmark icon-close"
data-room-jid=
"{{jid}}"
data-bookmark-name=
"{{name}}"
<a
class=
"remove-bookmark icon-close"
data-room-jid=
"{{jid}}"
data-bookmark-name=
"{{name}}"
title=
"{{info_remove}}"
href=
"#"
>
</a>
title=
"{{info_remove}}"
href=
"#"
>
</a>
<a
class=
"room-info icon-room-info"
data-room-jid=
"{{jid}}"
<a
class=
"room-info icon-room-info"
data-room-jid=
"{{jid}}"
title=
"{{info_title}}"
href=
"#"
>
</a>
title=
"{{info_title}}"
href=
"#"
>
</a>
</
li
>
</
dd
>
src/templates/bookmarks_list.html
View file @
1de2f714
<a
href=
"#"
class=
"bookmarks-toggle icon-{{toggle_state}}"
title=
"{{desc_bookmarks}}"
>
{{label_bookmarks}}
</a>
<a
href=
"#"
class=
"bookmarks-toggle icon-{{toggle_state}}"
title=
"{{desc_bookmarks}}"
>
{{label_bookmarks}}
</a>
<
ul
class=
"bookmarks"
></u
l>
<
dl
class=
"bookmarks rooms-list"
></d
l>
src/templates/room_panel.html
View file @
1de2f714
...
@@ -10,4 +10,4 @@
...
@@ -10,4 +10,4 @@
<input
type=
"button"
class=
"pure-button button-secondary"
name=
"show"
id=
"show-rooms"
value=
"{{label_show_rooms}}"
/>
<input
type=
"button"
class=
"pure-button button-secondary"
name=
"show"
id=
"show-rooms"
value=
"{{label_show_rooms}}"
/>
</fieldset>
</fieldset>
</form>
</form>
<dl
id=
"available-chatrooms"
></dl>
<dl
id=
"available-chatrooms"
class=
"rooms-list"
></dl>
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment