Add test for format string highlights

Signed-off-by: Michal Čihař <michal@cihar.com>

weblate/trans/tests/test_checks.py

@@ -206,8 +206,12 @@ class CheckTestCase(TestCase):
     def test_check_highlight(self):
         if self.check is None or self.test_highlight is None:
             return
-        unit = MockUnit(None, self.test_highlight[0])
+        unit = MockUnit(
+            None,
+            self.test_highlight[0],
+            source=self.test_highlight[1]
+        )
         self.assertEqual(
-            self.check.check_highlight(self.test_highlight[0], unit),
-            self.test_highlight[1]
+            self.check.check_highlight(self.test_highlight[1], unit),
+            self.test_highlight[2]
         )

weblate/trans/tests/test_format_checks.py

@@ -23,15 +23,22 @@ Tests for quality checks.
 """
 
 from __future__ import unicode_literals
-from unittest import TestCase
+from weblate.trans.tests.test_checks import CheckTestCase
 from weblate.trans.checks.format import (
     PythonFormatCheck, PHPFormatCheck, CFormatCheck, PythonBraceFormatCheck,
 )
 
 
-class PythonFormatCheckTest(TestCase):
+class PythonFormatCheckTest(CheckTestCase):
+    check = PythonFormatCheck()
+
     def setUp(self):
-        self.check = PythonFormatCheck()
+        super(PythonFormatCheckTest, self).setUp()
+        self.test_highlight = (
+            'python-format',
+            '%sstring%d',
+            [(0, u'%s'), (8, u'%d')],
+        )
 
     def test_no_format(self):
         self.assertFalse(self.check.check_format(
@@ -118,9 +125,16 @@ class PythonFormatCheckTest(TestCase):
         ))
 
 
-class PHPFormatCheckTest(TestCase):
+class PHPFormatCheckTest(CheckTestCase):
+    check = PHPFormatCheck()
+
     def setUp(self):
-        self.check = PHPFormatCheck()
+        super(PHPFormatCheckTest, self).setUp()
+        self.test_highlight = (
+            'php-format',
+            '%sstring%d',
+            [(0, u'%s'), (8, u'%d')],
+        )
 
     def test_no_format(self):
         self.assertFalse(self.check.check_format(
@@ -207,9 +221,16 @@ class PHPFormatCheckTest(TestCase):
         ))
 
 
-class CFormatCheckTest(TestCase):
+class CFormatCheckTest(CheckTestCase):
+    check = CFormatCheck()
+
     def setUp(self):
-        self.check = CFormatCheck()
+        super(CFormatCheckTest, self).setUp()
+        self.test_highlight = (
+            'c-format',
+            '%sstring%d',
+            [(0, u'%s'), (8, u'%d')],
+        )
 
     def test_no_format(self):
         self.assertFalse(self.check.check_format(
@@ -282,9 +303,16 @@ class CFormatCheckTest(TestCase):
         ))
 
 
-class PythonBraceFormatCheckTest(TestCase):
+class PythonBraceFormatCheckTest(CheckTestCase):
+    check = PythonBraceFormatCheck()
+
     def setUp(self):
-        self.check = PythonBraceFormatCheck()
+        super(PythonBraceFormatCheckTest, self).setUp()
+        self.test_highlight = (
+            'python-brace-format',
+            '{0}string{1}',
+            [(0, u'{0}'), (9, u'{1}')],
+        )
 
     def test_no_format(self):
         self.assertFalse(self.check.check_format(

weblate/trans/tests/test_markup_checks.py

@@ -38,6 +38,7 @@ class BBCodeCheckTest(CheckTestCase):
         self.test_failure_1 = ('[a]string[/a]', '[b]string[/b]', '')
         self.test_failure_2 = ('[a]string[/a]', 'string', '')
         self.test_highlight = (
+            '',
             '[a]string[/a]',
             [(0, '[a]'), (9, '[/a]')]
         )
@@ -53,6 +54,7 @@ class XMLTagsCheckTest(CheckTestCase):
         self.test_failure_2 = ('<a>string</a>', 'string', '')
         self.test_failure_3 = ('<a>string</a>', '<b>string</a>', '')
         self.test_highlight = (
+            '',
             '<b><a href="foo">bar</a></b>',
             [(0, '<b>'), (3, '<a href="foo">'), (20, '</a>'), (24, '</b>')]
         )