Support for not doing hooks in background (for testing and debugging)

docs/config.rst

@@ -50,6 +50,14 @@ Time in seconds for how long the automatic lock for translation will be active.
 
 .. seealso:: :ref:`locking`
 
+.. setting:: BACKGROUND_HOOKS
+
+BACKGROUND_HOOKS
+----------------
+
+Whether to run hooks in background. This is generally recommended unless you
+are debugging.
+
 .. setting:: CHECK_LIST
 
 CHECK_LIST

weblate/settings_example.py

@@ -306,6 +306,9 @@ EMAIL_SUBJECT_PREFIX = '[%s] ' % SITE_TITLE
 # Enable remote hooks
 ENABLE_HOOKS = True
 
+# Whether to run hooks in background
+BACKGROUND_HOOKS = True
+
 # Number of nearby messages to show in each direction
 NEARBY_MESSAGES = 5
 

weblate/trans/api.py

@@ -43,8 +43,11 @@ def update_subproject(request, project, subproject):
     if not appsettings.ENABLE_HOOKS:
         return HttpResponseNotAllowed([])
     obj = get_object_or_404(SubProject, slug=subproject, project__slug=project)
-    thread = threading.Thread(target=obj.do_update)
-    thread.start()
+    if appsettings.BACKGROUND_HOOKS:
+        thread = threading.Thread(target=obj.do_update)
+        thread.start()
+    else:
+        obj.do_update()
     return HttpResponse('update triggered')
 
 
@@ -56,8 +59,11 @@ def update_project(request, project):
     if not appsettings.ENABLE_HOOKS:
         return HttpResponseNotAllowed([])
     obj = get_object_or_404(Project, slug=project)
-    thread = threading.Thread(target=obj.do_update)
-    thread.start()
+    if appsettings.BACKGROUND_HOOKS:
+        thread = threading.Thread(target=obj.do_update)
+        thread.start()
+    else:
+        obj.do_update()
     return HttpResponse('update triggered')
 
 
@@ -96,8 +102,11 @@ def git_service_hook(request, service):
     )
     for obj in SubProject.objects.filter(repo=repo, branch=branch):
         logger.info('%s notification will update %s', obj)
-        thread = threading.Thread(target=obj.do_update)
-        thread.start()
+        if appsettings.BACKGROUND_HOOKS:
+            thread = threading.Thread(target=obj.do_update)
+            thread.start()
+        else:
+            obj.do_update()
 
     return HttpResponse('update triggered')
 

weblate/trans/appsettings.py

@@ -53,6 +53,9 @@ OFFER_HOSTING = get('OFFER_HOSTING', False)
 # Enable remote hooks
 ENABLE_HOOKS = get('ENABLE_HOOKS', True)
 
+# Whether to run hooks in background
+BACKGROUND_HOOKS = get('BACKGROUND_HOOKS', True)
+
 # Number of nearby messages to show in each direction
 NEARBY_MESSAGES = get('NEARBY_MESSAGES', 5)