Commit 8bb852b1 authored by JC Brand's avatar JC Brand

Updates #1554

Room auto-configuration broke if the config form contained fields with type `fixed`
parent 346baa68
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
- #1296: `embedded` view mode shows `chatbox-navback` arrow in header - #1296: `embedded` view mode shows `chatbox-navback` arrow in header
- #1532: Converse reloads on enter pressed in the filter box - #1532: Converse reloads on enter pressed in the filter box
- #1550: Legitimate carbons being blocked due to erroneous forgery check - #1550: Legitimate carbons being blocked due to erroneous forgery check
- #1554: Room auto-configuration broke if the config form contained fields with type `fixed`
- **Breaking changes**: - **Breaking changes**:
- Rename `muc_disable_moderator_commands` to [muc_disable_slash_commands](https://conversejs.org/docs/html/configuration.html#muc-disable-slash-commands). - Rename `muc_disable_moderator_commands` to [muc_disable_slash_commands](https://conversejs.org/docs/html/configuration.html#muc-disable-slash-commands).
......
...@@ -67523,6 +67523,11 @@ _converse_core__WEBPACK_IMPORTED_MODULE_3__["default"].plugins.add('converse-muc ...@@ -67523,6 +67523,11 @@ _converse_core__WEBPACK_IMPORTED_MODULE_3__["default"].plugins.add('converse-muc
*/ */
addFieldValue(field) { addFieldValue(field) {
const type = field.getAttribute('type'); const type = field.getAttribute('type');
if (type === 'fixed') {
return field;
}
const fieldname = field.getAttribute('var').replace('muc#roomconfig_', ''); const fieldname = field.getAttribute('var').replace('muc#roomconfig_', '');
const config = this.get('roomconfig'); const config = this.get('roomconfig');
...@@ -653,6 +653,9 @@ converse.plugins.add('converse-muc', { ...@@ -653,6 +653,9 @@ converse.plugins.add('converse-muc', {
*/ */
addFieldValue (field) { addFieldValue (field) {
const type = field.getAttribute('type'); const type = field.getAttribute('type');
if (type === 'fixed') {
return field;
}
const fieldname = field.getAttribute('var').replace('muc#roomconfig_', ''); const fieldname = field.getAttribute('var').replace('muc#roomconfig_', '');
const config = this.get('roomconfig'); const config = this.get('roomconfig');
if (fieldname in config) { if (fieldname in config) {
......
...@@ -45771,6 +45771,11 @@ _converse_core__WEBPACK_IMPORTED_MODULE_3__["default"].plugins.add('converse-muc ...@@ -45771,6 +45771,11 @@ _converse_core__WEBPACK_IMPORTED_MODULE_3__["default"].plugins.add('converse-muc
*/ */
addFieldValue(field) { addFieldValue(field) {
const type = field.getAttribute('type'); const type = field.getAttribute('type');
if (type === 'fixed') {
return field;
}
const fieldname = field.getAttribute('var').replace('muc#roomconfig_', ''); const fieldname = field.getAttribute('var').replace('muc#roomconfig_', '');
const config = this.get('roomconfig'); const config = this.get('roomconfig');
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment