Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
converse.js
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
converse.js
Commits
9edc9710
Commit
9edc9710
authored
Nov 30, 2016
by
JC Brand
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Don't maximize minimized rooms when calling `rooms.open`
parent
96d311e2
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
1 deletion
+8
-1
docs/CHANGES.md
docs/CHANGES.md
+1
-0
docs/source/developer_api.rst
docs/source/developer_api.rst
+2
-0
src/converse-minimize.js
src/converse-minimize.js
+2
-1
src/converse-muc.js
src/converse-muc.js
+3
-0
No files found.
docs/CHANGES.md
View file @
9edc9710
...
...
@@ -18,6 +18,7 @@
initialization is complete. [jcbrand]
-
New event
[
'reconnecting'
](
https://conversejs.org/docs/html/development.html#reconnecting
)
[
jcbrand
]
-
New configuration setting
[
allow_bookmarks
](
https://conversejs.org/docs/html/configuration.html#allow_bookmarks
)
[
jcbrand
]
-
The
`rooms.open`
API method will no longer maximize rooms that are minimized (unless
`maximize: true`
is passed in). [jcbrand]
## 2.0.1 (2016-11-07)
-
#203 New configuration setting
[
muc_domain
](
https://conversejs.org/docs/html/configuration.html#muc_domain
)
[
jcbrand
]
...
...
docs/source/developer_api.rst
View file @
9edc9710
...
...
@@ -578,6 +578,8 @@ Room attributes that may be passed in:
For a list of configuration values that can be passed in, refer to these values
in the `XEP-0045 MUC specification <http://xmpp.org/extensions/xep-0045.html#registrar-formtype-owner>`_.
The values should be named without the ``muc#roomconfig_`` prefix.
* *maximize*: A boolean, indicating whether minimized rooms should also be
maximized, when opened. Set to ``false`` by default.
For example, opening a room with a specific default configuration:
...
...
src/converse-minimize.js
View file @
9edc9710
...
...
@@ -196,7 +196,8 @@
/* Find the chat box and show it. If it doesn't exist, create it.
*/
var
chatbox
=
this
.
__super__
.
showChat
.
apply
(
this
,
arguments
);
if
(
chatbox
.
get
(
'
minimized
'
))
{
var
maximize
=
_
.
isUndefined
(
attrs
.
maximize
)
?
true
:
attrs
.
maximize
;
if
(
chatbox
.
get
(
'
minimized
'
)
&&
maximize
)
{
chatbox
.
maximize
();
}
return
chatbox
;
...
...
src/converse-muc.js
View file @
9edc9710
...
...
@@ -1830,6 +1830,9 @@
}
else
if
(
typeof
attrs
===
"
undefined
"
)
{
attrs
=
{};
}
if
(
_
.
isUndefined
(
attrs
.
maximize
))
{
attrs
.
maximize
=
false
;
}
var
fetcher
=
converse
.
chatboxviews
.
showChat
.
bind
(
converse
.
chatboxviews
);
if
(
!
attrs
.
nick
&&
converse
.
muc_nickname_from_jid
)
{
attrs
.
nick
=
Strophe
.
getNodeFromJid
(
converse
.
bare_jid
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment