Commit a4d608dc authored by JC Brand's avatar JC Brand

Save room features in separate model

As a namespacing mechanism to avoid clashes.
Fixes bug where two chats are shown as currently being active in the rooms list.
parent 0464772b
...@@ -3,6 +3,7 @@ ...@@ -3,6 +3,7 @@
## 4.0.7 (Unreleased) ## 4.0.7 (Unreleased)
- Bugfix: MUC commands were being ignored - Bugfix: MUC commands were being ignored
- Bugfix: Multiple rooms shown active in the rooms list
- UI: Always show the OMEMO lock icon (grayed out if not available). - UI: Always show the OMEMO lock icon (grayed out if not available).
- Use `publish-options` with `pubsub#access_model` set to `open` when publishing OMEMO public keys and devices - Use `publish-options` with `pubsub#access_model` set to `open` when publishing OMEMO public keys and devices
- Add a new `converse-pubsub` plugin, for generic PubSub operations - Add a new `converse-pubsub` plugin, for generic PubSub operations
......
This diff is collapsed.
...@@ -2141,13 +2141,13 @@ ...@@ -2141,13 +2141,13 @@
let view = _converse.chatboxviews.get('coven@chat.shakespeare.lit'); let view = _converse.chatboxviews.get('coven@chat.shakespeare.lit');
await test_utils.waitUntil(() => (view.model.get('connection_status') === converse.ROOMSTATUS.CONNECTING)); await test_utils.waitUntil(() => (view.model.get('connection_status') === converse.ROOMSTATUS.CONNECTING));
view = _converse.chatboxviews.get('coven@chat.shakespeare.lit'); view = _converse.chatboxviews.get('coven@chat.shakespeare.lit');
expect(view.model.get('features_fetched')).toBeTruthy(); expect(view.model.features.get('fetched')).toBeTruthy();
expect(view.model.get('passwordprotected')).toBe(true); expect(view.model.features.get('passwordprotected')).toBe(true);
expect(view.model.get('hidden')).toBe(true); expect(view.model.features.get('hidden')).toBe(true);
expect(view.model.get('temporary')).toBe(true); expect(view.model.features.get('temporary')).toBe(true);
expect(view.model.get('open')).toBe(true); expect(view.model.features.get('open')).toBe(true);
expect(view.model.get('unmoderated')).toBe(true); expect(view.model.features.get('unmoderated')).toBe(true);
expect(view.model.get('nonanonymous')).toBe(true); expect(view.model.features.get('nonanonymous')).toBe(true);
done(); done();
})); }));
...@@ -2172,19 +2172,19 @@ ...@@ -2172,19 +2172,19 @@
let features_list = chatroomview.el.querySelector('.features-list'); let features_list = chatroomview.el.querySelector('.features-list');
let features_shown = features_list.textContent.split('\n').map(s => s.trim()).filter(s => s); let features_shown = features_list.textContent.split('\n').map(s => s.trim()).filter(s => s);
expect(_.difference(["Password protected", "Open", "Temporary", "Not anonymous", "Not moderated"], features_shown).length).toBe(0); expect(_.difference(["Password protected", "Open", "Temporary", "Not anonymous", "Not moderated"], features_shown).length).toBe(0);
expect(chatroomview.model.get('hidden')).toBe(false); expect(chatroomview.model.features.get('hidden')).toBe(false);
expect(chatroomview.model.get('mam_enabled')).toBe(false); expect(chatroomview.model.features.get('mam_enabled')).toBe(false);
expect(chatroomview.model.get('membersonly')).toBe(false); expect(chatroomview.model.features.get('membersonly')).toBe(false);
expect(chatroomview.model.get('moderated')).toBe(false); expect(chatroomview.model.features.get('moderated')).toBe(false);
expect(chatroomview.model.get('nonanonymous')).toBe(true); expect(chatroomview.model.features.get('nonanonymous')).toBe(true);
expect(chatroomview.model.get('open')).toBe(true); expect(chatroomview.model.features.get('open')).toBe(true);
expect(chatroomview.model.get('passwordprotected')).toBe(true); expect(chatroomview.model.features.get('passwordprotected')).toBe(true);
expect(chatroomview.model.get('persistent')).toBe(false); expect(chatroomview.model.features.get('persistent')).toBe(false);
expect(chatroomview.model.get('publicroom')).toBe(true); expect(chatroomview.model.features.get('publicroom')).toBe(true);
expect(chatroomview.model.get('semianonymous')).toBe(false); expect(chatroomview.model.features.get('semianonymous')).toBe(false);
expect(chatroomview.model.get('temporary')).toBe(true); expect(chatroomview.model.features.get('temporary')).toBe(true);
expect(chatroomview.model.get('unmoderated')).toBe(true); expect(chatroomview.model.features.get('unmoderated')).toBe(true);
expect(chatroomview.model.get('unsecured')).toBe(false); expect(chatroomview.model.features.get('unsecured')).toBe(false);
expect(chatroomview.el.querySelector('.chat-title').textContent.trim()).toBe('Room'); expect(chatroomview.el.querySelector('.chat-title').textContent.trim()).toBe('Room');
chatroomview.el.querySelector('.configure-chatroom-button').click(); chatroomview.el.querySelector('.configure-chatroom-button').click();
...@@ -2304,7 +2304,7 @@ ...@@ -2304,7 +2304,7 @@
'muc_passwordprotected', 'muc_passwordprotected',
'muc_hidden', 'muc_hidden',
'muc_temporary', 'muc_temporary',
'muc_open', 'muc_membersonly',
'muc_unmoderated', 'muc_unmoderated',
'muc_nonanonymous' 'muc_nonanonymous'
]; ];
...@@ -2316,27 +2316,26 @@ ...@@ -2316,27 +2316,26 @@
.c('value').t('This is the description').up().up() .c('value').t('This is the description').up().up()
.c('field', {'type':'text-single', 'var':'muc#roominfo_occupants', 'label':'Number of occupants'}) .c('field', {'type':'text-single', 'var':'muc#roominfo_occupants', 'label':'Number of occupants'})
.c('value').t(0); .c('value').t(0);
_converse.connection._dataRecv(test_utils.createRequest(features_stanza));
spyOn(chatroomview.occupantsview, 'renderRoomFeatures').and.callThrough(); _converse.connection._dataRecv(test_utils.createRequest(features_stanza));
await test_utils.waitUntil(() => chatroomview.occupantsview.renderRoomFeatures.calls.count()); await test_utils.waitUntil(() => new Promise(success => chatroomview.model.features.on('change', success)));
features_list = chatroomview.el.querySelector('.features-list'); features_list = chatroomview.el.querySelector('.features-list');
features_shown = features_list.textContent.split('\n').map(s => s.trim()).filter(s => s); features_shown = features_list.textContent.split('\n').map(s => s.trim()).filter(s => s);
expect(_.difference(["Password protected", "Hidden", "Open", "Temporary", "Not anonymous", "Not moderated"], features_shown).length).toBe(0); expect(_.difference(["Password protected", "Hidden", "Members only", "Temporary", "Not anonymous", "Not moderated"], features_shown).length).toBe(0);
expect(chatroomview.model.get('hidden')).toBe(true); expect(chatroomview.model.features.get('hidden')).toBe(true);
expect(chatroomview.model.get('mam_enabled')).toBe(false); expect(chatroomview.model.features.get('mam_enabled')).toBe(false);
expect(chatroomview.model.get('membersonly')).toBe(false); expect(chatroomview.model.features.get('membersonly')).toBe(true);
expect(chatroomview.model.get('moderated')).toBe(false); expect(chatroomview.model.features.get('moderated')).toBe(false);
expect(chatroomview.model.get('nonanonymous')).toBe(true); expect(chatroomview.model.features.get('nonanonymous')).toBe(true);
expect(chatroomview.model.get('open')).toBe(true); expect(chatroomview.model.features.get('open')).toBe(false);
expect(chatroomview.model.get('passwordprotected')).toBe(true); expect(chatroomview.model.features.get('passwordprotected')).toBe(true);
expect(chatroomview.model.get('persistent')).toBe(false); expect(chatroomview.model.features.get('persistent')).toBe(false);
expect(chatroomview.model.get('publicroom')).toBe(false); expect(chatroomview.model.features.get('publicroom')).toBe(false);
expect(chatroomview.model.get('semianonymous')).toBe(false); expect(chatroomview.model.features.get('semianonymous')).toBe(false);
expect(chatroomview.model.get('temporary')).toBe(true); expect(chatroomview.model.features.get('temporary')).toBe(true);
expect(chatroomview.model.get('unmoderated')).toBe(true); expect(chatroomview.model.features.get('unmoderated')).toBe(true);
expect(chatroomview.model.get('unsecured')).toBe(false); expect(chatroomview.model.features.get('unsecured')).toBe(false);
expect(chatroomview.el.querySelector('.chat-title').textContent.trim()).toBe('New room name'); expect(chatroomview.el.querySelector('.chat-title').textContent.trim()).toBe('New room name');
done(); done();
})); }));
...@@ -3708,7 +3707,7 @@ ...@@ -3708,7 +3707,7 @@
.c('feature', {'var': 'muc_membersonly'}).up(); .c('feature', {'var': 'muc_membersonly'}).up();
_converse.connection._dataRecv(test_utils.createRequest(features_stanza)); _converse.connection._dataRecv(test_utils.createRequest(features_stanza));
await test_utils.waitUntil(() => (view.model.get('connection_status') === converse.ROOMSTATUS.CONNECTING)); await test_utils.waitUntil(() => (view.model.get('connection_status') === converse.ROOMSTATUS.CONNECTING));
expect(view.model.get('membersonly')).toBeTruthy(); expect(view.model.features.get('membersonly')).toBeTruthy();
test_utils.createContacts(_converse, 'current'); test_utils.createContacts(_converse, 'current');
......
...@@ -1254,13 +1254,13 @@ ...@@ -1254,13 +1254,13 @@
// Test that the button gets disabled when the room becomes // Test that the button gets disabled when the room becomes
// anonymous or semi-anonymous // anonymous or semi-anonymous
view.model.save({'nonanonymous': false, 'semianonymous': true}); view.model.features.save({'nonanonymous': false, 'semianonymous': true});
await test_utils.waitUntil(() => !view.model.get('omemo_supported')); await test_utils.waitUntil(() => !view.model.get('omemo_supported'));
toggle = toolbar.querySelector('.toggle-omemo'); toggle = toolbar.querySelector('.toggle-omemo');
expect(_.isNull(toggle)).toBe(true); expect(_.isNull(toggle)).toBe(true);
expect(view.model.get('omemo_supported')).toBe(false); expect(view.model.get('omemo_supported')).toBe(false);
view.model.save({'nonanonymous': true, 'semianonymous': false}); view.model.features.save({'nonanonymous': true, 'semianonymous': false});
await test_utils.waitUntil(() => view.model.get('omemo_supported')); await test_utils.waitUntil(() => view.model.get('omemo_supported'));
toggle = toolbar.querySelector('.toggle-omemo'); toggle = toolbar.querySelector('.toggle-omemo');
expect(_.isNull(toggle)).toBe(false); expect(_.isNull(toggle)).toBe(false);
...@@ -1269,12 +1269,12 @@ ...@@ -1269,12 +1269,12 @@
expect(u.hasClass('disabled', toggle)).toBe(false); expect(u.hasClass('disabled', toggle)).toBe(false);
// Test that the button gets disabled when the room becomes open // Test that the button gets disabled when the room becomes open
view.model.save({'membersonly': false, 'open': true}); view.model.features.save({'membersonly': false, 'open': true});
await test_utils.waitUntil(() => !view.model.get('omemo_supported')); await test_utils.waitUntil(() => !view.model.get('omemo_supported'));
toggle = toolbar.querySelector('.toggle-omemo'); toggle = toolbar.querySelector('.toggle-omemo');
expect(_.isNull(toggle)).toBe(true); expect(_.isNull(toggle)).toBe(true);
view.model.save({'membersonly': true, 'open': false}); view.model.features.save({'membersonly': true, 'open': false});
await test_utils.waitUntil(() => view.model.get('omemo_supported')); await test_utils.waitUntil(() => view.model.get('omemo_supported'));
toggle = toolbar.querySelector('.toggle-omemo'); toggle = toolbar.querySelector('.toggle-omemo');
expect(_.isNull(toggle)).toBe(false); expect(_.isNull(toggle)).toBe(false);
......
...@@ -236,7 +236,7 @@ converse.plugins.add('converse-muc-views', { ...@@ -236,7 +236,7 @@ converse.plugins.add('converse-muc-views', {
function toggleRoomInfo (ev) { function toggleRoomInfo (ev) {
/* Show/hide extra information about a groupchat in a listing. */ /* Show/hide extra information about a groupchat in a listing. */
const parent_el = u.ancestor(ev.target, '.room-item'), const parent_el = u.ancestor(ev.target, '.room-item'),
div_el = parent_el.querySelector('div.room-info'); div_el = parent_el.querySelector('div.room-info');
if (div_el) { if (div_el) {
u.slideIn(div_el).then(u.removeElement) u.slideIn(div_el).then(u.removeElement)
parent_el.querySelector('a.room-info').classList.remove('selected'); parent_el.querySelector('a.room-info').classList.remove('selected');
...@@ -439,9 +439,10 @@ converse.plugins.add('converse-muc-views', { ...@@ -439,9 +439,10 @@ converse.plugins.add('converse-muc-views', {
this.model.toJSON(), { this.model.toJSON(), {
'_': _, '_': _,
'__': __, '__': __,
'topic': u.addHyperlinks(xss.filterXSS(_.get(this.model.get('subject'), 'text'), {'whiteList': {}})),
'display_name': __('Groupchat info for %1$s', this.model.getDisplayName()), 'display_name': __('Groupchat info for %1$s', this.model.getDisplayName()),
'num_occupants': this.model.occupants.length 'features': this.model.features.toJSON(),
'num_occupants': this.model.occupants.length,
'topic': u.addHyperlinks(xss.filterXSS(_.get(this.model.get('subject'), 'text'), {'whiteList': {}}))
}) })
); );
} }
...@@ -1831,12 +1832,7 @@ converse.plugins.add('converse-muc-views', { ...@@ -1831,12 +1832,7 @@ converse.plugins.add('converse-muc-views', {
this.chatroomview = this.model.chatroomview; this.chatroomview = this.model.chatroomview;
this.chatroomview.model.on('change:open', this.renderInviteWidget, this); this.chatroomview.model.on('change:open', this.renderInviteWidget, this);
this.chatroomview.model.on('change:affiliation', this.renderInviteWidget, this); this.chatroomview.model.on('change:affiliation', this.renderInviteWidget, this);
this.chatroomview.model.on('change', () => { this.chatroomview.model.features.on('change', this.renderRoomFeatures, this);
if (_.intersection(converse.ROOM_FEATURES, Object.keys(this.chatroomview.model.changed)).length === 0) {
return;
}
this.renderRoomFeatures();
}, this);
this.render(); this.render();
this.model.fetch({ this.model.fetch({
...@@ -1882,16 +1878,15 @@ converse.plugins.add('converse-muc-views', { ...@@ -1882,16 +1878,15 @@ converse.plugins.add('converse-muc-views', {
}, },
renderRoomFeatures () { renderRoomFeatures () {
const picks = _.pick(this.chatroomview.model.attributes, converse.ROOM_FEATURES), const features = this.chatroomview.model.features,
iteratee = (a, v) => a || v, picks = _.pick(features.attributes, converse.ROOM_FEATURES),
el = this.el.querySelector('.chatroom-features'); iteratee = (a, v) => a || v;
el.innerHTML = tpl_chatroom_features( if (_.reduce(_.values(picks), iteratee)) {
_.extend(this.chatroomview.model.toJSON(), { const el = this.el.querySelector('.chatroom-features');
'__': __, el.innerHTML = tpl_chatroom_features(_.extend(features.toJSON(), {__}));
'has_features': _.reduce(_.values(picks), iteratee) this.setOccupantsHeight();
})); }
this.setOccupantsHeight();
return this; return this;
}, },
......
...@@ -446,7 +446,7 @@ converse.plugins.add('converse-omemo', { ...@@ -446,7 +446,7 @@ converse.plugins.add('converse-omemo', {
}, },
renderOMEMOToolbarButton () { renderOMEMOToolbarButton () {
if (this.model.get('membersonly') && this.model.get('nonanonymous')) { if (this.model.features.get('membersonly') && this.model.features.get('nonanonymous')) {
this.__super__.renderOMEMOToolbarButton.apply(arguments); this.__super__.renderOMEMOToolbarButton.apply(arguments);
} else { } else {
const icon = this.el.querySelector('.toggle-omemo'); const icon = this.el.querySelector('.toggle-omemo');
...@@ -1137,7 +1137,7 @@ converse.plugins.add('converse-omemo', { ...@@ -1137,7 +1137,7 @@ converse.plugins.add('converse-omemo', {
} }
async function onOccupantAdded (chatroom, occupant) { async function onOccupantAdded (chatroom, occupant) {
if (occupant.isSelf() || !chatroom.get('nonanonymous') || !chatroom.get('membersonly')) { if (occupant.isSelf() || !chatroom.features.get('nonanonymous') || !chatroom.features.get('membersonly')) {
return; return;
} }
if (chatroom.get('omemo_active')) { if (chatroom.get('omemo_active')) {
...@@ -1157,7 +1157,7 @@ converse.plugins.add('converse-omemo', { ...@@ -1157,7 +1157,7 @@ converse.plugins.add('converse-omemo', {
let supported; let supported;
if (chatbox.get('type') === _converse.CHATROOMS_TYPE) { if (chatbox.get('type') === _converse.CHATROOMS_TYPE) {
await _converse.api.waitUntil('OMEMOInitialized'); await _converse.api.waitUntil('OMEMOInitialized');
supported = chatbox.get('nonanonymous') && chatbox.get('membersonly'); supported = chatbox.features.get('nonanonymous') && chatbox.features.get('membersonly');
} else if (chatbox.get('type') === _converse.PRIVATE_CHAT_TYPE) { } else if (chatbox.get('type') === _converse.PRIVATE_CHAT_TYPE) {
supported = await _converse.contactHasOMEMOSupport(chatbox.get('jid')); supported = await _converse.contactHasOMEMOSupport(chatbox.get('jid'));
} }
...@@ -1169,8 +1169,7 @@ converse.plugins.add('converse-omemo', { ...@@ -1169,8 +1169,7 @@ converse.plugins.add('converse-omemo', {
checkOMEMOSupported(chatbox); checkOMEMOSupported(chatbox);
if (chatbox.get('type') === _converse.CHATROOMS_TYPE) { if (chatbox.get('type') === _converse.CHATROOMS_TYPE) {
chatbox.occupants.on('add', o => onOccupantAdded(chatbox, o)); chatbox.occupants.on('add', o => onOccupantAdded(chatbox, o));
chatbox.on('change:nonanonymous', checkOMEMOSupported); chatbox.features.on('change', () => checkOMEMOSupported(chatbox));
chatbox.on('change:membersonly', checkOMEMOSupported);
} }
}) })
); );
......
...@@ -795,7 +795,7 @@ _converse.initialize = function (settings, callback) { ...@@ -795,7 +795,7 @@ _converse.initialize = function (settings, callback) {
this.initSession = function () { this.initSession = function () {
const id = b64_sha1('converse.bosh-session'); const id = 'converse.bosh-session';
_converse.session = new Backbone.Model({id}); _converse.session = new Backbone.Model({id});
_converse.session.browserStorage = new Backbone.BrowserStorage.session(id); _converse.session.browserStorage = new Backbone.BrowserStorage.session(id);
_converse.session.fetch(); _converse.session.fetch();
......
...@@ -159,9 +159,7 @@ converse.plugins.add('converse-muc', { ...@@ -159,9 +159,7 @@ converse.plugins.add('converse-muc', {
defaults () { defaults () {
return _.assign( return _.assign(
_.clone(_converse.ChatBox.prototype.defaults), _.clone(_converse.ChatBox.prototype.defaults), {
_.zipObject(converse.ROOM_FEATURES, _.map(converse.ROOM_FEATURES, _.stubFalse)),
{
// For group chats, we distinguish between generally unread // For group chats, we distinguish between generally unread
// messages and those ones that specifically mention the // messages and those ones that specifically mention the
// user. // user.
...@@ -177,7 +175,6 @@ converse.plugins.add('converse-muc', { ...@@ -177,7 +175,6 @@ converse.plugins.add('converse-muc', {
'name': '', 'name': '',
'nick': _converse.xmppstatus.get('nickname') || _converse.nickname, 'nick': _converse.xmppstatus.get('nickname') || _converse.nickname,
'description': '', 'description': '',
'features_fetched': false,
'roomconfig': {}, 'roomconfig': {},
'type': _converse.CHATROOMS_TYPE, 'type': _converse.CHATROOMS_TYPE,
'message_type': 'groupchat' 'message_type': 'groupchat'
...@@ -189,6 +186,14 @@ converse.plugins.add('converse-muc', { ...@@ -189,6 +186,14 @@ converse.plugins.add('converse-muc', {
this.constructor.__super__.initialize.apply(this, arguments); this.constructor.__super__.initialize.apply(this, arguments);
this.on('change:connection_status', this.onConnectionStatusChanged, this); this.on('change:connection_status', this.onConnectionStatusChanged, this);
const storage = _converse.config.get('storage');
const id = `converse.muc-features-${_converse.bare_jid}-${this.get('jid')}`;
this.features = new Backbone.Model(
_.assign({id}, _.zipObject(converse.ROOM_FEATURES, _.map(converse.ROOM_FEATURES, _.stubFalse)))
);
this.features.browserStorage = new Backbone.BrowserStorage.session(id);
this.features.fetch();
this.occupants = new _converse.ChatRoomOccupants(); this.occupants = new _converse.ChatRoomOccupants();
this.occupants.browserStorage = new Backbone.BrowserStorage.session( this.occupants.browserStorage = new Backbone.BrowserStorage.session(
b64_sha1(`converse.occupants-${_converse.bare_jid}${this.get('jid')}`) b64_sha1(`converse.occupants-${_converse.bare_jid}${this.get('jid')}`)
...@@ -304,6 +309,7 @@ converse.plugins.add('converse-muc', { ...@@ -304,6 +309,7 @@ converse.plugins.add('converse-muc', {
* (String) exit_msg: Optional message to indicate your * (String) exit_msg: Optional message to indicate your
* reason for leaving. * reason for leaving.
*/ */
this.features.destroy();
this.occupants.browserStorage._clear(); this.occupants.browserStorage._clear();
this.occupants.reset(); this.occupants.reset();
if (_converse.disco_entities) { if (_converse.disco_entities) {
...@@ -496,14 +502,25 @@ converse.plugins.add('converse-muc', { ...@@ -496,14 +502,25 @@ converse.plugins.add('converse-muc', {
return this.getRoomFeatures(); return this.getRoomFeatures();
}, },
async getRoomIdentity () {
const [identity, fields] = await Promise.all([
_converse.api.disco.getIdentity('conference', 'text', this.get('jid')),
_converse.api.disco.getFields(this.get('jid'))
]);
this.save({
'name': identity && identity.get('name'),
'description': _.get(fields.findWhere({'var': "muc#roominfo_description"}), 'attributes.value')
});
},
async getRoomFeatures () { async getRoomFeatures () {
// XXX: not sure whet the right place is to get the room identitiy
this.getRoomIdentity();
const features = await _converse.api.disco.getFeatures(this.get('jid')), const features = await _converse.api.disco.getFeatures(this.get('jid')),
fields = await _converse.api.disco.getFields(this.get('jid')), attrs = _.extend(
identity = await _converse.api.disco.getIdentity('conference', 'text', this.get('jid')), _.zipObject(converse.ROOM_FEATURES, _.map(converse.ROOM_FEATURES, _.stubFalse)),
attrs = _.extend(_.zipObject(converse.ROOM_FEATURES, _.map(converse.ROOM_FEATURES, _.stubFalse)), { {'fetched': moment().format()}
'features_fetched': moment().format(), );
'name': identity && identity.get('name')
});
features.each(feature => { features.each(feature => {
const fieldname = feature.get('var'); const fieldname = feature.get('var');
...@@ -515,8 +532,7 @@ converse.plugins.add('converse-muc', { ...@@ -515,8 +532,7 @@ converse.plugins.add('converse-muc', {
} }
attrs[fieldname.replace('muc_', '')] = true; attrs[fieldname.replace('muc_', '')] = true;
}); });
attrs.description = _.get(fields.findWhere({'var': "muc#roominfo_description"}), 'attributes.value'); this.features.save(attrs);
this.save(attrs);
}, },
requestMemberList (affiliation) { requestMemberList (affiliation) {
...@@ -1053,7 +1069,7 @@ converse.plugins.add('converse-muc', { ...@@ -1053,7 +1069,7 @@ converse.plugins.add('converse-muc', {
this.trigger('configurationNeeded'); this.trigger('configurationNeeded');
return; // We haven't yet entered the groupchat, so bail here. return; // We haven't yet entered the groupchat, so bail here.
} }
} else if (!this.get('features_fetched')) { } else if (!this.features.get('fetched')) {
// The features for this groupchat weren't fetched. // The features for this groupchat weren't fetched.
// That must mean it's a new groupchat without locking // That must mean it's a new groupchat without locking
// (in which case Prosody doesn't send a 201 status), // (in which case Prosody doesn't send a 201 status),
......
...@@ -18,43 +18,43 @@ ...@@ -18,43 +18,43 @@
<p class="room-info"><strong>{{{o.__('Features')}}}</strong>: <p class="room-info"><strong>{{{o.__('Features')}}}</strong>:
<div class="chatroom-features"> <div class="chatroom-features">
<ul class="features-list"> <ul class="features-list">
{[ if (o.passwordprotected) { ]} {[ if (o.features.passwordprotected) { ]}
<li class="feature" ><span class="fa fa-lock"></span>{{{ o.__('Password protected') }}} - <em>{{{ o.__('This groupchat requires a password before entry') }}}</em></li> <li class="feature" ><span class="fa fa-lock"></span>{{{ o.__('Password protected') }}} - <em>{{{ o.__('This groupchat requires a password before entry') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.unsecured) { ]} {[ if (o.features.unsecured) { ]}
<li class="feature" ><span class="fa fa-unlock"></span>{{{ o.__('No password required') }}} - <em>{{{ o.__('This groupchat does not require a password upon entry') }}}</em></li> <li class="feature" ><span class="fa fa-unlock"></span>{{{ o.__('No password required') }}} - <em>{{{ o.__('This groupchat does not require a password upon entry') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.hidden) { ]} {[ if (o.features.hidden) { ]}
<li class="feature" ><span class="fa fa-eye-slash"></span>{{{ o.__('Hidden') }}} - <em>{{{ o.__('This groupchat is not publicly searchable') }}}</em></li> <li class="feature" ><span class="fa fa-eye-slash"></span>{{{ o.__('Hidden') }}} - <em>{{{ o.__('This groupchat is not publicly searchable') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.public_room) { ]} {[ if (o.features.public_room) { ]}
<li class="feature" ><span class="fa fa-eye"></span>{{{ o.__('Public') }}} - <em>{{{ o.__('This groupchat is publicly searchable') }}}</em></li> <li class="feature" ><span class="fa fa-eye"></span>{{{ o.__('Public') }}} - <em>{{{ o.__('This groupchat is publicly searchable') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.membersonly) { ]} {[ if (o.features.membersonly) { ]}
<li class="feature" ><span class="fa fa-address-book"></span>{{{ o.__('Members only') }}} - <em>{{{ o.__('This groupchat is restricted to members only') }}}</em></li> <li class="feature" ><span class="fa fa-address-book"></span>{{{ o.__('Members only') }}} - <em>{{{ o.__('This groupchat is restricted to members only') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.open) { ]} {[ if (o.features.open) { ]}
<li class="feature" ><span class="fa fa-globe"></span>{{{ o.__('Open') }}} - <em>{{{ o.__('Anyone can join this groupchat') }}}</em></li> <li class="feature" ><span class="fa fa-globe"></span>{{{ o.__('Open') }}} - <em>{{{ o.__('Anyone can join this groupchat') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.persistent) { ]} {[ if (o.features.persistent) { ]}
<li class="feature" ><span class="fa fa-save"></span>{{{ o.__('Persistent') }}} - <em>{{{ o.__('This groupchat persists even if it\'s unoccupied') }}}</em></li> <li class="feature" ><span class="fa fa-save"></span>{{{ o.__('Persistent') }}} - <em>{{{ o.__('This groupchat persists even if it\'s unoccupied') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.temporary) { ]} {[ if (o.features.temporary) { ]}
<li class="feature" ><span class="fa fa-snowflake-o"></span>{{{ o.__('Temporary') }}} - <em>{{{ o.__('This groupchat will disappear once the last person leaves') }}}</em></li> <li class="feature" ><span class="fa fa-snowflake-o"></span>{{{ o.__('Temporary') }}} - <em>{{{ o.__('This groupchat will disappear once the last person leaves') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.nonanonymous) { ]} {[ if (o.features.nonanonymous) { ]}
<li class="feature" ><span class="fa fa-id-card"></span>{{{ o.__('Not anonymous') }}} - <em>{{{ o.__('All other groupchat participants can see your XMPP username') }}}</em></li> <li class="feature" ><span class="fa fa-id-card"></span>{{{ o.__('Not anonymous') }}} - <em>{{{ o.__('All other groupchat participants can see your XMPP username') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.semianonymous) { ]} {[ if (o.features.semianonymous) { ]}
<li class="feature" ><span class="fa fa-user-secret"></span>{{{ o.__('Semi-anonymous') }}} - <em>{{{ o.__('Only moderators can see your XMPP username') }}}</em></li> <li class="feature" ><span class="fa fa-user-secret"></span>{{{ o.__('Semi-anonymous') }}} - <em>{{{ o.__('Only moderators can see your XMPP username') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.moderated) { ]} {[ if (o.features.moderated) { ]}
<li class="feature" ><span class="fa fa-gavel"></span>{{{ o.__('Moderated') }}} - <em>{{{ o.__('Participants entering this groupchat need to request permission to write') }}}</em></li> <li class="feature" ><span class="fa fa-gavel"></span>{{{ o.__('Moderated') }}} - <em>{{{ o.__('Participants entering this groupchat need to request permission to write') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.unmoderated) { ]} {[ if (o.features.unmoderated) { ]}
<li class="feature" ><span class="fa fa-info-circle"></span>{{{ o.__('Not moderated') }}} - <em>{{{ o.__('Participants entering this groupchat can write right away') }}}</em></li> <li class="feature" ><span class="fa fa-info-circle"></span>{{{ o.__('Not moderated') }}} - <em>{{{ o.__('Participants entering this groupchat can write right away') }}}</em></li>
{[ } ]} {[ } ]}
{[ if (o.mam_enabled) { ]} {[ if (o.features.mam_enabled) { ]}
<li class="feature" ><span class="fa fa-database"></span>{{{ o.__('Message archiving') }}} - <em>{{{ o.__('Messages are archived on the server') }}}</em></li> <li class="feature" ><span class="fa fa-database"></span>{{{ o.__('Message archiving') }}} - <em>{{{ o.__('Messages are archived on the server') }}}</em></li>
{[ } ]} {[ } ]}
</ul> </ul>
......
{[ if (o.has_features) { ]}
<p class="occupants-heading">{{{o.__('Features')}}}</p> <p class="occupants-heading">{{{o.__('Features')}}}</p>
{[ } ]}
<ul class="features-list"> <ul class="features-list">
{[ if (o.passwordprotected) { ]} {[ if (o.passwordprotected) { ]}
<li class="feature" title="{{{ o.__('This groupchat requires a password before entry') }}}"><span class="fa fa-lock"></span>{{{ o.__('Password protected') }}}</li> <li class="feature" title="{{{ o.__('This groupchat requires a password before entry') }}}"><span class="fa fa-lock"></span>{{{ o.__('Password protected') }}}</li>
...@@ -24,7 +22,7 @@ ...@@ -24,7 +22,7 @@
<li class="feature" title="{{{ o.__('This groupchat persists even if it\'s unoccupied') }}}"><span class="fa fa-save"></span>{{{ o.__('Persistent') }}}</li> <li class="feature" title="{{{ o.__('This groupchat persists even if it\'s unoccupied') }}}"><span class="fa fa-save"></span>{{{ o.__('Persistent') }}}</li>
{[ } ]} {[ } ]}
{[ if (o.temporary) { ]} {[ if (o.temporary) { ]}
<li class="feature" title="{{{ o.__('This groupchat will disappear once the last person leaves') }}}"><span class="fa fa-snowflake-o"></span>{{{ o.__('Temporary') }}}</li> <li class="feature" title="{{{ o.__('This groupchat will disappear once the last person leaves') }}}"><span class="fa fa-snowflake"></span>{{{ o.__('Temporary') }}}</li>
{[ } ]} {[ } ]}
{[ if (o.nonanonymous) { ]} {[ if (o.nonanonymous) { ]}
<li class="feature" title="{{{ o.__('All other groupchat participants can see your XMPP username') }}}"><span class="fa fa-id-card"></span>{{{ o.__('Not anonymous') }}}</li> <li class="feature" title="{{{ o.__('All other groupchat participants can see your XMPP username') }}}"><span class="fa fa-id-card"></span>{{{ o.__('Not anonymous') }}}</li>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment