Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
converse.js
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Commits
Issue Boards
Open sidebar
nexedi
converse.js
Commits
d048cff9
Commit
d048cff9
authored
Apr 18, 2018
by
JC Brand
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Provide metadata of file being uploaded.
updates #161
parent
463b0e6a
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
90 additions
and
3 deletions
+90
-3
spec/http-file-upload.js
spec/http-file-upload.js
+82
-1
src/converse-chatboxes.js
src/converse-chatboxes.js
+1
-1
src/converse-message-view.js
src/converse-message-view.js
+6
-1
src/templates/file.html
src/templates/file.html
+1
-0
No files found.
spec/http-file-upload.js
View file @
d048cff9
...
@@ -174,7 +174,6 @@
...
@@ -174,7 +174,6 @@
describe
(
"
When supported
"
,
function
()
{
describe
(
"
When supported
"
,
function
()
{
describe
(
"
A file upload toolbar button
"
,
function
()
{
describe
(
"
A file upload toolbar button
"
,
function
()
{
it
(
"
appears in private chats
"
,
mock
.
initConverseWithAsync
(
function
(
done
,
_converse
)
{
it
(
"
appears in private chats
"
,
mock
.
initConverseWithAsync
(
function
(
done
,
_converse
)
{
...
@@ -442,6 +441,88 @@
...
@@ -442,6 +441,88 @@
}));
}));
});
});
});
});
describe
(
"
While a file is being uploaded
"
,
function
()
{
it
(
"
shows a progress bar
"
,
mock
.
initConverseWithAsync
(
function
(
done
,
_converse
)
{
test_utils
.
waitUntilDiscoConfirmed
(
_converse
,
_converse
.
domain
,
[{
'
category
'
:
'
server
'
,
'
type
'
:
'
IM
'
}],
[
'
http://jabber.org/protocol/disco#items
'
],
[],
'
info
'
).
then
(
function
()
{
var
send_backup
=
XMLHttpRequest
.
prototype
.
send
;
var
IQ_stanzas
=
_converse
.
connection
.
IQ_stanzas
;
test_utils
.
waitUntilDiscoConfirmed
(
_converse
,
_converse
.
domain
,
[],
[],
[
'
upload.montague.tld
'
],
'
items
'
).
then
(
function
()
{
test_utils
.
waitUntilDiscoConfirmed
(
_converse
,
'
upload.montague.tld
'
,
[],
[
Strophe
.
NS
.
HTTPUPLOAD
],
[]).
then
(
function
()
{
test_utils
.
createContacts
(
_converse
,
'
current
'
);
var
contact_jid
=
mock
.
cur_names
[
2
].
replace
(
/ /g
,
'
.
'
).
toLowerCase
()
+
'
@localhost
'
;
test_utils
.
openChatBoxFor
(
_converse
,
contact_jid
);
var
view
=
_converse
.
chatboxviews
.
get
(
contact_jid
);
var
file
=
{
'
type
'
:
'
image/jpeg
'
,
'
size
'
:
'
23456
'
,
'
lastModifiedDate
'
:
""
,
'
name
'
:
"
my-juliet.jpg
"
};
view
.
model
.
sendFiles
([
file
]);
return
test_utils
.
waitUntil
(
function
()
{
return
_
.
filter
(
IQ_stanzas
,
function
(
iq
)
{
return
iq
.
nodeTree
.
querySelector
(
'
iq[to="upload.montague.tld"] request
'
);
}).
length
>
0
;
}).
then
(
function
()
{
var
iq
=
IQ_stanzas
.
pop
();
expect
(
iq
.
toLocaleString
()).
toBe
(
"
<iq from='dummy@localhost/resource'
"
+
"
to='upload.montague.tld'
"
+
"
type='get'
"
+
"
xmlns='jabber:client'
"
+
"
id='
"
+
iq
.
nodeTree
.
getAttribute
(
'
id
'
)
+
"
'>
"
+
"
<request xmlns='urn:xmpp:http:upload:0'
"
+
"
filename='my-juliet.jpg'
"
+
"
size='23456'
"
+
"
content-type='image/jpeg'/>
"
+
"
</iq>
"
);
var
base_url
=
document
.
URL
.
split
(
window
.
location
.
pathname
)[
0
];
var
message
=
base_url
+
"
/logo/conversejs-filled.svg
"
;
var
stanza
=
Strophe
.
xmlHtmlNode
(
"
<iq from='upload.montague.tld'
"
+
"
id='
"
+
iq
.
nodeTree
.
getAttribute
(
'
id
'
)
+
"
'
"
+
"
to='dummy@localhost/resource'
"
+
"
type='result'>
"
+
"
<slot xmlns='urn:xmpp:http:upload:0'>
"
+
"
<put url='https://upload.montague.tld/4a771ac1-f0b2-4a4a-9700-f2a26fa2bb67/my-juliet.jpg'>
"
+
"
<header name='Authorization'>Basic Base64String==</header>
"
+
"
<header name='Cookie'>foo=bar; user=romeo</header>
"
+
"
</put>
"
+
"
<get url='
"
+
message
+
"
' />
"
+
"
</slot>
"
+
"
</iq>
"
).
firstElementChild
;
spyOn
(
XMLHttpRequest
.
prototype
,
'
send
'
).
and
.
callFake
(
function
()
{
const
message
=
view
.
model
.
messages
.
at
(
0
);
expect
(
view
.
el
.
querySelector
(
'
.chat-content progress
'
).
getAttribute
(
'
value
'
)).
toBe
(
'
0
'
);
message
.
set
(
'
progress
'
,
0.5
);
expect
(
view
.
el
.
querySelector
(
'
.chat-content progress
'
).
getAttribute
(
'
value
'
)).
toBe
(
'
0.5
'
);
message
.
set
(
'
progress
'
,
1
);
expect
(
view
.
el
.
querySelector
(
'
.chat-content progress
'
).
getAttribute
(
'
value
'
)).
toBe
(
'
1
'
);
expect
(
view
.
el
.
querySelector
(
'
.chat-content .chat-msg-content
'
).
textContent
).
toBe
(
'
Uploading file: my-juliet.jpg, 22.91 KB
'
);
done
();
});
var
sent_stanza
;
spyOn
(
_converse
.
connection
,
'
send
'
).
and
.
callFake
(
function
(
stanza
)
{
sent_stanza
=
stanza
;
});
_converse
.
connection
.
_dataRecv
(
test_utils
.
createRequest
(
stanza
));
});
});
});
});
}));
});
});
});
});
});
}));
}));
src/converse-chatboxes.js
View file @
d048cff9
...
@@ -129,7 +129,7 @@
...
@@ -129,7 +129,7 @@
}
else
{
}
else
{
return
this
.
save
({
return
this
.
save
({
'
type
'
:
'
error
'
,
'
type
'
:
'
error
'
,
'
message
'
:
__
(
"
Sorry, could not determine upload URL.
"
)
'
message
'
:
__
(
"
Sorry, could not determine
file
upload URL.
"
)
});
});
}
}
}).
catch
((
e
)
=>
{
}).
catch
((
e
)
=>
{
...
...
src/converse-message-view.js
View file @
d048cff9
...
@@ -9,6 +9,7 @@
...
@@ -9,6 +9,7 @@
"
converse-core
"
,
"
converse-core
"
,
"
xss
"
,
"
xss
"
,
"
emojione
"
,
"
emojione
"
,
"
filesize
"
,
"
tpl!action
"
,
"
tpl!action
"
,
"
tpl!file
"
,
"
tpl!file
"
,
"
tpl!info
"
,
"
tpl!info
"
,
...
@@ -19,6 +20,7 @@
...
@@ -19,6 +20,7 @@
converse
,
converse
,
xss
,
xss
,
emojione
,
emojione
,
filesize
,
tpl_action
,
tpl_action
,
tpl_file
,
tpl_file
,
tpl_info
,
tpl_info
,
...
@@ -119,7 +121,10 @@
...
@@ -119,7 +121,10 @@
},
},
renderFileUploadProgresBar
()
{
renderFileUploadProgresBar
()
{
const
msg
=
u
.
stringToElement
(
tpl_file
(
this
.
model
.
toJSON
()));
const
msg
=
u
.
stringToElement
(
tpl_file
(
_
.
extend
(
this
.
model
.
toJSON
(),
{
'
filesize
'
:
filesize
(
this
.
model
.
get
(
'
file
'
).
size
)}
)));
return
this
.
replaceElement
(
msg
);
return
this
.
replaceElement
(
msg
);
},
},
...
...
src/templates/file.html
View file @
d048cff9
<div
class=
"message"
data-isodate=
"{{{o.time}}}"
data-msgid=
"{{{o.msgid}}}"
>
<div
class=
"message"
data-isodate=
"{{{o.time}}}"
data-msgid=
"{{{o.msgid}}}"
>
<span
class=
"chat-msg-content"
>
Uploading file:
<strong>
{{{o.file.name}}}
</strong>
, {{{o.filesize}}}
</span>
<progress
value=
"{{{o.progress}}}"
/>
<progress
value=
"{{{o.progress}}}"
/>
</div>
</div>
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment