Ignore messages without a body

d2933b89 · JC Brand · 705c0438 · d2933b89
Commit d2933b89 authored Jun 17, 2016 by JC Brand
Hide whitespace changes
Inline Side-by-side

Showing with 5 additions and 2 deletions

src/converse-notification.js src/converse-notification.js +5 -2

No files found.
--- a/src/converse-notification.js
+++ b/src/converse-notification.js
@@ -63,8 +63,11 @@
                    return false;
                }
                var room = converse.chatboxes.get(room_jid);
-                var body = $message.children('body').text();
+                var $body = $message.children('body');
-                var mentioned = (new RegExp("\\b"+room.get('nick')+"\\b")).test(body);
+                if (!$body.length) {
+                    return false;
+                }
+                var mentioned = (new RegExp("\\b"+room.get('nick')+"\\b")).test($body.text());
                notify_all = notify_all === true || (_.isArray(notify_all) && _.contains(notify_all, room_jid));
                if (sender === room.get('nick') || (!notify_all && !mentioned)) {
                    return false;