Commit 4df7b1ec authored by Stefan Behnel's avatar Stefan Behnel

test runner: check for thread termination after each test

parent 9785287b
...@@ -20,6 +20,11 @@ try: ...@@ -20,6 +20,11 @@ try:
except ImportError: except ImportError:
import pickle import pickle
try:
import threading
except ImportError: # No threads, no problems
threading = None
WITH_CYTHON = True WITH_CYTHON = True
...@@ -433,9 +438,12 @@ class CythonRunTestCase(CythonCompileTestCase): ...@@ -433,9 +438,12 @@ class CythonRunTestCase(CythonCompileTestCase):
result.startTest(self) result.startTest(self)
try: try:
self.setUp() self.setUp()
self.runCompileTest() try:
if not self.cython_only: self.runCompileTest()
self.run_doctests(self.module, result) if not self.cython_only:
self.run_doctests(self.module, result)
finally:
check_thread_termination()
except Exception: except Exception:
result.addError(self, sys.exc_info()) result.addError(self, sys.exc_info())
result.stopTest(self) result.stopTest(self)
...@@ -530,6 +538,7 @@ class PureDoctestTestCase(unittest.TestCase): ...@@ -530,6 +538,7 @@ class PureDoctestTestCase(unittest.TestCase):
del m del m
if loaded_module_name in sys.modules: if loaded_module_name in sys.modules:
del sys.modules[loaded_module_name] del sys.modules[loaded_module_name]
check_thread_termination()
except Exception: except Exception:
result.addError(self, sys.exc_info()) result.addError(self, sys.exc_info())
result.stopTest(self) result.stopTest(self)
...@@ -601,8 +610,11 @@ class CythonUnitTestCase(CythonCompileTestCase): ...@@ -601,8 +610,11 @@ class CythonUnitTestCase(CythonCompileTestCase):
result.startTest(self) result.startTest(self)
try: try:
self.setUp() self.setUp()
self.runCompileTest() try:
unittest.defaultTestLoader.loadTestsFromName(self.module).run(result) self.runCompileTest()
unittest.defaultTestLoader.loadTestsFromName(self.module).run(result)
finally:
check_thread_termination()
except Exception: except Exception:
result.addError(self, sys.exc_info()) result.addError(self, sys.exc_info())
result.stopTest(self) result.stopTest(self)
...@@ -836,6 +848,23 @@ def refactor_for_py3(distdir, cy3_dir): ...@@ -836,6 +848,23 @@ def refactor_for_py3(distdir, cy3_dir):
''') ''')
sys.path.insert(0, cy3_dir) sys.path.insert(0, cy3_dir)
def check_thread_termination():
if threading is None: # no threading enabled in CPython
return
current = threading.currentThread()
blocking_threads = []
for t in threading.enumerate():
if not t.isAlive() or t == current:
continue
t.join(timeout=2)
if t.isAlive():
blocking_threads.append(t)
if not blocking_threads:
return
sys.stderr.write("warning: left-over threads found after running test:\n")
for t in blocking_threads:
sys.stderr.write('...%s\n' % repr(t))
raise RuntimeError("left-over threads found after running test")
if __name__ == '__main__': if __name__ == '__main__':
from optparse import OptionParser from optparse import OptionParser
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment