Fix a compiler crash when looking up cython.view.array() as a callable...

Fix a compiler crash when looking up cython.view.array() as a callable function with non-trivial keyword arguments.

Closes #1598.

Cython/Compiler/ParseTreeTransforms.py

@@ -3020,10 +3020,10 @@ class TransformBuiltinMethods(EnvTransform):
 
     def visit_GeneralCallNode(self, node):
         function = node.function.as_cython_attribute()
-        if function:
+        if function == u'cast':
+            # NOTE: assuming simple tuple/dict nodes for positional_args and keyword_args
             args = node.positional_args.args
             kwargs = node.keyword_args.compile_time_value(None)
-            if function == u'cast':
             if (len(args) != 2 or len(kwargs) > 1 or
                     (len(kwargs) == 1 and 'typecheck' not in kwargs)):
                 error(node.function.pos,

tests/memoryview/cythonarray.pyx

@@ -2,6 +2,7 @@
 
 from __future__ import unicode_literals
 
+# these imports allow testing different ways to access [[cython.]view.]array()
 from cython.view cimport array
 from cython cimport view as v
 cimport cython as cy
@@ -20,7 +21,7 @@ def contiguity():
     2 3
     2
     '''
-    cdef v.array cvarray = v.array(shape=(2,3), itemsize=sizeof(int), format="i", mode='c')
+    cdef v.array cvarray = cy.view.array(shape=(2,3), itemsize=sizeof(int), format="i", mode='c')
     assert cvarray.len == 2*3*sizeof(int), (cvarray.len, 2*3*sizeof(int))
     assert cvarray.itemsize == sizeof(int)
     print cvarray.strides[0], cvarray.strides[1]