Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
nexedi
cython
Commits
93935811
Commit
93935811
authored
Sep 07, 2020
by
Xavier Thompson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Improve 'Bugfix: Fix cpp iteration over attribute of temporary object' using 'is_simple()' method
parent
e52f7f3e
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
18 deletions
+1
-18
Cython/Compiler/ExprNodes.py
Cython/Compiler/ExprNodes.py
+1
-18
No files found.
Cython/Compiler/ExprNodes.py
View file @
93935811
...
...
@@ -293,23 +293,6 @@ def translate_double_cpp_exception(code, pos, lhs_type, lhs_code, rhs_code, lhs_
code
.
putln
(
code
.
error_goto
(
pos
))
code
.
putln
(
'}'
)
# Used to determine if a node has a persistent result, meaning it is not temporary
# and doesn't depend on any temporary sub expressions.
# Examples:
# name # <- persistent
# name.attr # <- persistent
# some_func() # <- temporary
# some_func().attr # <- temporary
# Essentially this boils down to NameNodes and AttributeNodes that are recursively
# only composed of NameNodes.
def
is_persistent
(
node
):
if
node
.
is_name
:
return
True
elif
node
.
is_attribute
:
return
is_persistent
(
node
.
obj
)
else
:
return
False
class
ExprNode
(
Node
):
# subexprs [string] Class var holding names of subexpr node attrs
...
...
@@ -2937,7 +2920,7 @@ class CppIteratorNode(ExprNode):
if
sequence_type
.
is_cyp_class
:
self
.
cpp_attribute_op
=
"->"
# essentially 3 options:
if
is_persistent
(
self
.
sequence
):
if
self
.
sequence
.
is_simple
(
):
# 1) is a name and can be accessed directly;
# assigning to it may break the container, but that's the responsibility
# of the user
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment