always optimise tuple(some_list), not only for literals

99da1f3a · Stefan Behnel · bb09b855 · 99da1f3a
Commit 99da1f3a authored Sep 15, 2009 by Stefan Behnel
Hide whitespace changes
Inline Side-by-side

Showing with 3 additions and 2 deletions

Cython/Compiler/Optimize.py Cython/Compiler/Optimize.py +3 -2

No files found.
--- a/Cython/Compiler/Optimize.py
+++ b/Cython/Compiler/Optimize.py
@@ -667,8 +667,9 @@ class OptimizeBuiltinCalls(Visitor.VisitorTransform):
            return node
        if not isinstance(list_arg, (ExprNodes.ComprehensionNode,
                                     ExprNodes.ListNode)):
-            # everything else may be None => take the safe path
+            pos_args.args[0] = ExprNodes.NoneCheckNode(
-            return node
+                list_arg, "PyExc_TypeError",
+                "'NoneType' object is not iterable")
        return ExprNodes.PythonCapiCallNode(
            node.pos, "PyList_AsTuple", self.PyList_AsTuple_func_type,