Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in / Register
Toggle navigation
C
cython
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Labels
Merge Requests
0
Merge Requests
0
Analytics
Analytics
Repository
Value Stream
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Commits
Open sidebar
nexedi
cython
Commits
a7b9dcd8
Commit
a7b9dcd8
authored
Jul 04, 2019
by
gsamain
Committed by
Xavier Thompson
Aug 17, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make del unlock object only if it was locked (segfault if done in with locked bloc)
parent
a5f1ce5a
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
1 deletion
+4
-1
Cython/Compiler/Nodes.py
Cython/Compiler/Nodes.py
+4
-1
No files found.
Cython/Compiler/Nodes.py
View file @
a7b9dcd8
...
...
@@ -6359,6 +6359,7 @@ class DelStatNode(StatNode):
child_attrs
=
[
"args"
]
ignore_nonexisting
=
False
was_locked
=
False
def
analyse_declarations
(
self
,
env
):
for
arg
in
self
.
args
:
...
...
@@ -6373,6 +6374,8 @@ class DelStatNode(StatNode):
error
(
arg
.
pos
,
"Deletion of global C variable"
)
elif
arg
.
type
.
is_ptr
and
arg
.
type
.
base_type
.
is_cpp_class
or
arg
.
type
.
is_cyp_class
:
self
.
cpp_check
(
env
)
if
arg
.
type
.
is_cyp_class
:
self
.
was_locked
=
arg
.
needs_rlock
()
or
arg
.
needs_wlock
()
elif
arg
.
type
.
is_cpp_class
:
error
(
arg
.
pos
,
"Deletion of non-heap C++ object"
)
elif
arg
.
is_subscript
and
arg
.
base
.
type
is
Builtin
.
bytearray_type
:
...
...
@@ -6404,7 +6407,7 @@ class DelStatNode(StatNode):
arg
.
free_temps
(
code
)
elif
arg
.
type
.
is_cyp_class
:
arg
.
generate_evaluation_code
(
code
)
if
arg
.
type
.
lock_mode
==
"autolock"
:
if
arg
.
type
.
lock_mode
==
"autolock"
and
self
.
was_locked
:
code
.
putln
(
"Cy_UNLOCK(%s);"
%
arg
.
result
())
code
.
putln
(
"Cy_DECREF(%s);"
%
arg
.
result
())
code
.
putln
(
"%s = NULL;"
%
arg
.
result
())
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment