fixed display of hidden fields

data/computer_fieldlist.json

@@ -49,7 +49,7 @@
       "description": "The reference number for this computer.",
       "description_i18n": "portal_type_dict.computer_dict.field_list.reference.description",
       "alternate_name": "computer_reference",
-      "default_value": null,
+      "default_value": "COMP-1234",
       "css_class": null,
       "hidden": false,
       "display_width": 30,
@@ -58,7 +58,7 @@
     },
     "properties": {
       "enabled": true,
-      "editable": true,
+      "editable": false,
       "external_validator": null,
       "required": true,
       "preserve_whitespace": null,

data/computer_new.json

@@ -42,7 +42,8 @@
         }, {
           "position": "center",
           "fieldlist": [
-            {"title": "computer_description"}
+            {"title": "computer_description"},
+            {"title": "computer_reference", "overrides": {"widget":{"hidden": true}}}
           ]
         }
       ]

js/erp5_loader.js

@@ -867,6 +867,8 @@
         }
 
         // construct config
+        // NOTE: type is always set in attributes, because it can be null
+        // on select/textarea
         config.type = element;
         config.direct = {
           "id": (prevail.widget.id || spec.widget.id),
@@ -3386,7 +3388,7 @@
       label_inside, label_target, element_target, action, clear,
       theme, icon_string, input_type, need_text_node, container_class_list,
       label_class_list, index, disabled, active, text, addLabel, readonly,
-      mask_set, mask, star;
+      mask_set, mask, star, hidden_field;
 
     if (config.type === "span") {
       return factory.element(
@@ -3465,13 +3467,18 @@
       mask_set = true;
     }
 
+    // hidden
+    if (config.attributes.type === "hidden") {
+      hidden_field = true;
+    }
+
     // mask
     if (mask_set) {
       mask = " ui-mask-input";
     }
 
     // fieldcontain wrapper
-    if (wrap === false || wrap === undefined) {
+    if (wrap === false || wrap === undefined || hidden_field) {
       wrapper = document.createDocumentFragment();
     } else {
       wrapper = factory.element(
@@ -3562,7 +3569,7 @@
 
     // container
     if (config.type === "textarea" ||
-        config.direct.type === "hidden" ||
+        hidden_field ||
           config.logic.plain_element) {
       container = wrapper;
     } else {
@@ -3606,7 +3613,7 @@
     // doing "invalid" handler with javascript
     // NOTE: hidden fields & security fields get no label
     if (need_text_node === undefined &&
-        !label_inside &&
+        !label_inside && !hidden_field &&
           config.logic.plain_element === undefined) {
       label_target.appendChild(addLabel(config, label_class_list));
     }