app: cleanup

js/erp5_loader.js

@@ -6135,12 +6135,8 @@
 
             return RSVP.all(promise_list)
               .then(function (response_list) {
-                if (!response_list[0]) {
-                  app.util.loader(
-                    "",
-                    "status_dict.internal_error",
-                    "ban-circle"
-                  );
+                if (!response_list[0] && promise_list.length !== 0) {
+                  app.util.loader("", "status_dict.internal_error", "ban");
                 }
                 // just return pass and continue
                 return {
@@ -6926,11 +6922,11 @@
         // set values or flag for subordination inside map.element
         default:
           kid.logic[key] = kid.logic[key] || "";
-
           if (val.split("subordinate_").length > 1) {
 
             // NOTE: try to get value from state/URL before flagging
             // NOTE: must check for equality, otherwise id foo > foofoo
+            // TODO: this is still super-not-robust... redo!
             lookup = wrapper.property_dict.state.query.query;
             if (lookup && lookup.indexOf(val) > -1) {
               new_val = lookup.split(val)[1].split("+")[0]
@@ -6943,9 +6939,6 @@
             }
           } else {
             kid.logic[key] += wrapper.property_dict.data.doc[val];
-//             if (key === "href") {
-//               kid.logic[key] = window.encodeURIComponent(kid.logic[key]);
-//             }
             delete kid.logic.setParam[i];
           }
       }