app: adding TODOs and small optimizations

js/erp5_loader.js

@@ -2418,9 +2418,9 @@
     for (section in config) {
       if (config.hasOwnProperty(section)) {
         arr = config[section];
+
         if (typeof arr === "object" && arr !== null) {
-          len = arr.length;
-          for (k = 0; k < len; k += 1) {
+          for (k = 0, len = arr.length; k < len; k += 1) {
             block = arr[k];
             content = factory.util.generateContentElement(
               block.type,
@@ -2438,6 +2438,7 @@
         }
       }
     }
+    // TODO: return an object...
     return [fragment, appendix, class_string];
   };
 
@@ -3440,6 +3441,7 @@
   // TODO: action_menu input + form?
   // TODO: how to handle translations of record texts?
   // TODO: subordinate handling
+  // TODO: pick translations from field_dict for header!
   map.tableItem = function (spec) {
     var j, k, segment, row, cell, id, quirk_dict, record, new_item, item;
 
@@ -3543,7 +3545,7 @@
       // loop scheme fields
       for (k = 0; k < section.field_list.length; k += 1) {
         field = section.field_list[k];
-        key = field.value || field.field;
+        key = field.value || field.field || "";
         relation = key.split("subordinate_");
         pass = {
           "record": record,
@@ -3624,23 +3626,25 @@
     // TODO: remove this crap or make it generic...
     // set = setter_list ... JSLINT
     setValue = function (setter) {
-      var n, len, set_value, set_flux, set, val, set_reference;
+      var n, len, set_value, set_flux, set, val, set_reference, logic,
+        selection, split;
 
-      if (setter.logic) {
-        set_reference = setter.logic.setReference;
-        set_value = setter.logic.setValue;
-        val = setter.logic.lookupValue;
-        set = setter.logic.setters;
-        set_flux = setter.logic.setFlux;
+      logic = setter.logic;
+      if (logic) {
+        set_reference = logic.setReference;
+        set_value = logic.setValue;
+        val = logic.lookupValue;
+        set = logic.setters;
+        set_flux = logic.setFlux;
 
         if (set) {
           len = set.length;
           for (n = 0; n < len; n += 1) {
             if (val) {
               // FU§$%&/NG HAL
-              setter.logic[set[n]] = item.doc[val[n][0]][val[n][1]][val[n][2]];
+              logic[set[n]] = item.doc[val[n][0]][val[n][1]][val[n][2]];
             } else {
-              setter.logic[set[n]] = item.doc[set_value];
+              logic[set[n]] = item.doc[set_value];
             }
           }
         } else if (set_value) {