Simulation Rules: do not specify list of portal types to getMovementList

getMovementList will already return appropriate movements, this is
redundancy and it prevent using DeliveryRootSimulationRule for some
Orders on some projects

product/ERP5/Document/DeliveryRootSimulationRule.py

@@ -80,7 +80,12 @@ class DeliveryRootSimulationRule(RuleMixin, MovementCollectionUpdaterMixin):
 class DeliveryRuleMovementGenerator(MovementGeneratorMixin):
 
   def _getPortalDeliveryMovementTypeList(self):
-    return self._rule.getPortalObject().getPortalDeliveryMovementTypeList()
+    """
+    Allow to override to use only some particular types of delivery lines
+
+    # This is bad XXX-JPS - use use
+    """
+    return None
 
   def _getInputMovementList(self, movement_list=None, rounding=None):
     """Input movement list comes from delivery"""
@@ -89,8 +94,11 @@ class DeliveryRuleMovementGenerator(MovementGeneratorMixin):
       return []
     else:
       result = []
-      for movement in delivery.getMovementList(
-        portal_type=self._getPortalDeliveryMovementTypeList()):
+      movement_kw = {}
+      movement_type_list = self._getPortalDeliveryMovementTypeList()
+      if movement_type_list:
+        movement_kw["portal_type"] = movement_type_list
+      for movement in delivery.getMovementList(**movement_kw):
         simulation_movement_list = movement.getDeliveryRelatedValueList()
         if not simulation_movement_list or self._applied_rule in (
             simulation_movement.getParentValue()

product/ERP5/Document/OrderRootSimulationRule.py

@@ -95,5 +95,4 @@ class OrderRuleMovementGenerator(MovementGeneratorMixin):
     if order is None:
       return []
     else:
-      return order.getMovementList(
-        portal_type=order.getPortalOrderMovementTypeList())
+      return order.getMovementList()