Skip to content

erp5
erp5
Commit 0d8242de authored by Jérome Perrin's avatar Jérome Perrin
Browse files
Options

accounting: fix grouping dialog loosing section category on next page 

In xhtml_style, just after clicking next or previous page in the listbox
buttons, the values selected in 'Section Category' and 'Section Category
Strict' were not used, because they were used from request and not from
as normal script parameters.

This fixes only the xhtml_style version, ERP5JS has another problem that
dialog fields values are reset when going to next page, so it would also
need this problem to be fixed.
parent 9405ec7d
Pipeline #22674 failed with stage
    Expand all Hide whitespace changes
    Inline Side-by-side
    Showing with 433 additions and 166 deletions
    bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountingTransactionModule_getTransactionLineListForGroupingReference.py
    View file @ 0d8242de
    ...@@ -4,7 +4,7 @@ request = container.REQUEST ...@@ -4,7 +4,7 @@ request = container.REQUEST
    portal = context.getPortalObject() portal = context.getPortalObject()
    # we use a different selection for dialog params, because we never want this # we use a different selection for dialog params, because we never want this
    # selection to be reseteted # selection to be reset
    dialog_selection_params = portal.portal_selections.getSelectionParamsFor( dialog_selection_params = portal.portal_selections.getSelectionParamsFor(
    'grouping_reference_fast_input_selection') 'grouping_reference_fast_input_selection')
    ...@@ -26,12 +26,20 @@ for column in portal.portal_selections.getSelectionSortOrder( ...@@ -26,12 +26,20 @@ for column in portal.portal_selections.getSelectionSortOrder(
    continue continue
    sort_on.append((column_id, column[1])) sort_on.append((column_id, column[1]))
    section_category = request.get( # XXX ERP5JS does call list method with selection parameters, so we have to read in request.
    'section_category', section_category = section_category \
    portal.portal_preferences.getPreferredAccountingTransactionSectionCategory()) or request.get('section_category') \
    section_category_strict = request.get( or dialog_selection_params.get('section_category') \
    'section_category_strict', or portal.portal_preferences.getPreferredAccountingTransactionSectionCategory()
    portal.portal_preferences.getPreferredAccountingSectionCategoryStrict()) for candidate in (
    section_category_strict,
    request.get('section_category_strict'),
    dialog_selection_params.get('section_category_strict'),
    portal.portal_preferences.getPreferredAccountingSectionCategoryStrict(),
    ):
    if candidate is not None:
    section_category_strict = candidate
    break
    section_uid = portal.Base_getSectionUidListForSectionCategory( section_uid = portal.Base_getSectionUidListForSectionCategory(
    section_category, section_category_strict) section_category, section_category_strict)
    ......
    bt5/erp5_accounting/SkinTemplateItem/portal_skins/erp5_accounting/AccountingTransactionModule_getTransactionLineListForGroupingReference.xml
    View file @ 0d8242de
    ...@@ -50,7 +50,7 @@ ...@@ -50,7 +50,7 @@
    </item> </item>
    <item> <item>
    <key> <string>_params</string> </key> <key> <string>_params</string> </key>
    <value> <string>selection=None, grouping=\'grouping\', node=\'\', mirror_section=\'\', ledger=\'\', title=None, delivery_reference=None, debit_price=None, credit_price=None, date=None, **kw</string> </value> <value> <string>selection=None, grouping=\'grouping\', node=\'\', mirror_section=\'\', ledger=\'\', title=None, delivery_reference=None, debit_price=None, credit_price=None, date=None, section_category=\'\', section_category_strict=None, **kw</string> </value>
    </item> </item>
    <item> <item>
    <key> <string>id</string> </key> <key> <string>id</string> </key>
    ......
    bt5/erp5_accounting_ui_test/PathTemplateItem/portal_tests/accounting_zuite/test_grouping_reference/test_group_multi_pages_section_selection.html.xml 0 → 100644
    View file @ 0d8242de
    <?xml version="1.0"?>
    <ZopeData>
    <record id="1" aka="AAAAAAAAAAE=">
    <pickle>
    <global name="ZopePageTemplate" module="Products.PageTemplates.ZopePageTemplate"/>
    </pickle>
    <pickle>
    <dictionary>
    <item>
    <key> <string>_bind_names</string> </key>
    <value>
    <object>
    <klass>
    <global name="NameAssignments" module="Shared.DC.Scripts.Bindings"/>
    </klass>
    <tuple/>
    <state>
    <dictionary>
    <item>
    <key> <string>_asgns</string> </key>
    <value>
    <dictionary>
    <item>
    <key> <string>name_subpath</string> </key>
    <value> <string>traverse_subpath</string> </value>
    </item>
    </dictionary>
    </value>
    </item>
    </dictionary>
    </state>
    </object>
    </value>
    </item>
    <item>
    <key> <string>content_type</string> </key>
    <value> <string>text/html</string> </value>
    </item>
    <item>
    <key> <string>expand</string> </key>
    <value> <int>0</int> </value>
    </item>
    <item>
    <key> <string>id</string> </key>
    <value> <string>test_group_multi_pages_section_selection.html</string> </value>
    </item>
    <item>
    <key> <string>output_encoding</string> </key>
    <value> <string>utf-8</string> </value>
    </item>
    <item>
    <key> <string>title</string> </key>
    <value> <unicode></unicode> </value>
    </item>
    </dictionary>
    </pickle>
    </record>
    </ZopeData>
    bt5/erp5_accounting_ui_test/PathTemplateItem/portal_tests/accounting_zuite/test_grouping_reference/test_group_multi_pages_section_selection.html.zpt 0 → 100644
    View file @ 0d8242de
    <html>
    <head><title>Grouping with multiple pages and section selection</title></head>
    <body>
    <table cellpadding="1" cellspacing="1" border="1">
    <thead>
    <tr><td rowspan="1" colspan="4">
    Grouping with multiple pages and section selection
    </td></tr>
    </thead><tbody tal:define="init_method string:AccountingTransactionModule_createAccountingTransactionList?add_draft_transactions:int=0&month_count:int=6&add_related_payments:int=1&both_sections:int=1">
    <!-- Setup {{{ -->
    <tal:block metal:use-macro="here/ERP5Site_viewAccountingZuiteCommonTemplate/macros/init"/>
    <tr>
    <td>selectAndWait</td>
    <td>select_module</td>
    <td>Organisations</td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>Folder_show:method</td>
    <td></td>
    </tr>
    <tr>
    <td>type</td>
    <!-- title -->
    <td>//tr[@class='listbox-search-line']/th[2]/input</td>
    <td>Client 1</td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//input[@class="listbox-select-action"]</td>
    <td></td>
    </tr>
    <!-- }}} -->
    <!-- {{{ Select Client 1 Organisation and use grouping fast input -->
    <tr>
    <td>clickAndWait</td>
    <td>link=Client 1</td>
    <td></td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//img[@alt='Grouping Reference Fast Input']</td>
    <td></td>
    </tr>
    <!-- The mode should be 'grouping' by default -->
    <tr>
    <td>verifyValue</td>
    <td>//input[@name='field_your_grouping' and @value='grouping']</td>
    <td>on</td>
    </tr>
    <tr>
    <td>verifyText</td>
    <td>//label[contains(text(),"Total Selected Amount")]/../div[1]/</td>
    <td>0.00</td>
    </tr>
    <tr>
    <td>verifySelectedLabel</td>
    <td>field_your_node</td>
    <td></td>
    </tr>
    <tr>
    <td>select</td>
    <td>field_your_node</td>
    <td>label=41 - Receivable</td>
    </tr>
    <tr>
    <td>verifySelectedLabel</td>
    <td>field_your_section_category</td>
    <td>Demo Group</td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//button[@id="dialog_update_button"]</td>
    <td></td>
    </tr>
    <tr>
    <td>assertPortalStatusMessage</td>
    <td>Updated</td>
    <td></td>
    </tr>
    <tr>
    <td>assertText</td>
    <td>//span[@class="listbox-current-page-total-number"]</td>
    <td>24 records</td>
    </tr>
    <tr>
    <td>select</td>
    <td>field_your_section_category</td>
    <td>Demo Group</td>
    </tr>
    <tr>
    <td>click</td>
    <td>field_your_section_category_strict</td>
    <td></td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//button[@id="dialog_update_button"]</td>
    <td></td>
    </tr>
    <tr>
    <td>assertPortalStatusMessage</td>
    <td>Updated</td>
    <td></td>
    </tr>
    <tr>
    <td>assertText</td>
    <td>//span[@class="listbox-current-page-total-number"]</td>
    <td>12 records</td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//button[@class='listbox_next_page']</td>
    <td></td>
    </tr>
    <tr>
    <td>verifyText</td>
    <td>//span[@class='listbox-current-page-total-number']</td>
    <td>12 records</td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//button[@class='listbox_previous_page']</td>
    <td></td>
    </tr>
    <tr>
    <td>verifyText</td>
    <td>//span[@class='listbox-current-page-total-number']</td>
    <td>12 records</td>
    </tr>
    <tr>
    <td>assertChecked</td>
    <td>field_your_section_category_strict</td>
    <td></td>
    </tr>
    <tr>
    <td>click</td>
    <td>field_your_section_category_strict</td>
    <td></td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//button[@id="dialog_update_button"]</td>
    <td></td>
    </tr>
    <tr>
    <td>assertPortalStatusMessage</td>
    <td>Updated</td>
    <td></td>
    </tr>
    <tr>
    <td>assertText</td>
    <td>//span[@class="listbox-current-page-total-number"]</td>
    <td>24 records</td>
    </tr>
    <tr>
    <td>select</td>
    <td>field_your_section_category</td>
    <td>Demo Group/Subsidiairy #1</td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//button[@id="dialog_update_button"]</td>
    <td></td>
    </tr>
    <tr>
    <td>assertPortalStatusMessage</td>
    <td>Updated</td>
    <td></td>
    </tr>
    <tr>
    <td>assertText</td>
    <td>//span[@class="listbox-current-page-total-number"]</td>
    <td>12 records</td>
    </tr>
    <tr>
    <td>clickAndWait</td>
    <td>//button[@class='listbox_next_page']</td>
    <td></td>
    </tr>
    <tr>
    <td>verifyText</td>
    <td>//span[@class='listbox-current-page-total-number']</td>
    <td>12 records</td>
    </tr>
    </tbody></table>
    </body>
    </html>
    \ No newline at end of file
    bt5/erp5_accounting_ui_test/SkinTemplateItem/portal_skins/erp5_accounting_ui_test/AccountingTransactionModule_createAccountingTransactionList.xml
    View file @ 0d8242de
    ...@@ -50,7 +50,7 @@ ...@@ -50,7 +50,7 @@
    </item> </item>
    <item> <item>
    <key> <string>_params</string> </key> <key> <string>_params</string> </key>
    <value> <string>month_count=1, add_draft_transactions=1, transaction_state=\'validated\', add_related_payments=0, keep_grouping_reference=0, set_ledger=0</string> </value> <value> <string>month_count=1, add_draft_transactions=1, transaction_state=\'validated\', add_related_payments=0, keep_grouping_reference=0, set_ledger=0, both_sections=0</string> </value>
    </item> </item>
    <item> <item>
    <key> <string>id</string> </key> <key> <string>id</string> </key>
    ......
    Markdown is supported
    0% or
    You are about to add 0 people to the discussion. Proceed with caution.
    Finish editing this message first!
    Please register or to comment
    GitLab Nexedi Edition | About GitLab | About Nexedi | 沪ICP备2021021310号-2 | 沪ICP备2021021310号-7