Commit 0ed3d3d6 authored by Jérome Perrin's avatar Jérome Perrin

fixup! erp5_system_event: Add follow_up_title to 'More Columns' of System Event Module listbox

The term (used for example on HTTPExchange_view/my_follow_up_title ) is
"Follow-up". This will fix testNamingConventions failure.
parent a953f2c6
master DateTime.equalTo_fix TMP-2to3 UpdateValidationStateFromConsistency UserPropertySheet_backward_compatibility addToDate_implicit_localtime add_boolean_type arnau arnau-RD-Components-CacheTool arnau-RD-Components-ERP5Form-ERP5Report arnau-RD-Components-ERP5Form-SelectionTool-MemcachedTool arnau-RD-Components-ERP5OOo arnau-RD-Components-PreferenceTool-Preference arnau-RD-Components-Products-import-compat arnau-RD-Components-astroid_cache_per_component_reset arnau-RD-Components-erp5_crm arnau-RD-Components-erp5_trade-TODO-Interactor arnau-RD-ERP5ify-portal_workflow-1-seb-merged-with-recent-master arnau-RD-ERP5ify-portal_workflow-2-do-not-rename-erp5_workflow-portal_types arnau-RD-ERP5ify-portal_workflow-BAK arnau-RD-ERP5ify-portal_workflow-WIP arnau-RD-ERP5ify-portal_workflow-WITHOUT-MIGRATION arnau-RD-ERP5ify-portal_workflow-WORKFLOWS-NOT-MIGRATED arnau-RD-py3-master-TM arnau-RD-py3-master-TM-BAK arnau-RD-py3-master-WIP arnau-RD-py3-master-WIP-BAK arnau-RD-py3-master-WIP-bt5-and-tests arnau-RD-zope4py3 arnau-TM-Components-Migrate-PortalTransforms arnau-TM-Components-ModuleSecurityInfo arnau-TM-WIP arnau-TM-newContent-temp_object arnau-TM-wkhtmltopdf arnau-WIP arnau-my2to3 arnau-zope4py2 aurel-zope4py2 cache-control-304-response cribjs-bootloader drop-ZServer e2e-erp5 enhance_scalability_testing erp5-component erp5-component-bak erp5-vifib erp5-vifib-no-Products.DCWorkflowGraph erp5-vifib-py3 erp5_drone_simulator erp5_payslip_migration feat/coding_style_test feat/dedup_roles_in_pickles feat/dms_implicit_predecessor_successor_fields feat/erp5_ide feat/erp5pt feat/fsum feat/improve_rounding_tool feat/inventory_api_group_by_time_interval_list feat/lxml-html-snapshot feat/mariadb-10.11 feat/mariadb-10.11bis feat/mariadb-10.11ter feat/mariadb-10.5 feat/mariadb-10.6 feat/mariadb-11.4bis feat/mariadb-11.4bis-old feat/mariadb-11.4ter feat/notification-message-ignore-missing feat/python_language_support feat/reindexlastobjects_log feat/round_half_up feat/selenium-unexpected-success feat/slapos_agent_distributor feat/subject_set_query filter_actions fix/GHSA-g5vw-3h65-2q3v fix/TALES_hide_error fix/ZMI_editor_preference fix/advance_ecommerce_coding_crimes fix/erp5_site_global_id fix/mariadb-1927 fix/monaco-altClick fix/officejs_support_request_rss_secu fix/state_var fix/testnode_proctitle fix/workflow_info fix/workflow_method_security fix_web_illustration for_testrunner_1 for_testrunner_2 for_testrunner_3 graphic_gadget_js limit_accelerated_http_cache_manager lle-bout/metadata-modules master_w mr1362 my2to3 notebook_roque oauth-login-minor-improvement override_cache_control_header_by_caching_policy_manager poc/json-forms-study restore-from-trashbin revert-192c2000 rfc/activate_default rjs_listbox_sort_icon roque_quick scalability_crash_mariadb shop-box-rebase support_legacy_sftp_server support_relative_url_in_hyperlink_field support_request test-renderjs-float-field-step test_cmfactivity_isolation_level test_dynamic_methods tomo_testnode_slap_request translatable_path_master trustable-x-forwarded-for unify_predicate_edit without_legacy_workflow workaround_mroonga_14 wsgi_backport_setbody_lock wsgi_medusa_stream_fix zope2 zope2zope4py2 zope4py3 zope4py3-BEFORE-CLEANUP zope4py3-master-rebase nexedi-erp5-vifib-20201105 erp5.util-0.4.76 erp5.util-0.4.75 erp5.util-0.4.74 erp5.util-0.4.73 erp5.util-0.4.72 erp5.util-0.4.71 erp5.util-0.4.69 erp5.util-0.4.68 erp5.util-0.4.67 erp5.util-0.4.66 erp5.util-0.4.65 erp5.util-0.4.64 erp5.util-0.4.63 erp5-vifib-20240326 erp5-vifib-20230331 erp5-vifib-20230201 erp5-vifib-20220526 erp5-vifib-20220302 erp5-vifib-20210707 erp5-vifib-20201229 erp5-vifib-20200129
No related merge requests found
......@@ -80,7 +80,7 @@
<list>
<tuple>
<string>follow_up_title</string>
<string>Follow Up</string>
<string>Follow-up</string>
</tuple>
<tuple>
<string>creation_date</string>
......
  • @jerome , is it because we consider the word is 'follow-up' and not 'follow up'? So convention for title should end up to Follow-up?

  • I think so, but honestly for that change I just use the same spelling of existing fields ( HTTPExchange_view/my_follow_up_title ).

    when I search for follow up on dictionaries, I get suggested follow-up instead

    image

    image

    I just noticed that on portal_categories/follow_up it is "Follow Up", that looks incorrect.

  • Agreed, it makes sense. Thanks for fixing and notifying!

Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment